Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pylint #3190

Merged
merged 3 commits into from
Feb 23, 2019
Merged

Fix pylint #3190

merged 3 commits into from
Feb 23, 2019

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Feb 22, 2019

nmuesch
nmuesch previously approved these changes Feb 22, 2019
@codecov
Copy link

codecov bot commented Feb 22, 2019

Codecov Report

Merging #3190 into master will decrease coverage by 5.96%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3190      +/-   ##
==========================================
- Coverage   84.59%   78.63%   -5.97%     
==========================================
  Files         681        8     -673     
  Lines       36766      234   -36532     
  Branches     4331       22    -4309     
==========================================
- Hits        31103      184   -30919     
+ Misses       4398       38    -4360     
+ Partials     1265       12    -1253

@ofek ofek changed the title Fix pylint Remove print statement Feb 23, 2019
truthbk
truthbk previously approved these changes Feb 23, 2019
Copy link
Contributor

@zippolyte zippolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can’t remove that, this is how the agent gets the path of the wheel for installation. It parses stdout

@truthbk truthbk closed this Feb 23, 2019
@ofek ofek reopened this Feb 23, 2019
@ofek ofek merged commit 2c62717 into master Feb 23, 2019
@ofek ofek deleted the ofek/pylint branch February 23, 2019 19:06
@ofek ofek changed the title Remove print statement Fix pylint Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants