Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move exceptions to their own submodule #3180

Merged
merged 4 commits into from
Feb 21, 2019
Merged

Move exceptions to their own submodule #3180

merged 4 commits into from
Feb 21, 2019

Conversation

trishankatdatadog
Copy link
Member

What does this PR do?

Separate module for exceptions.

Motivation

Cleaner code.

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • Feature or bugfix must have tests
  • Git history must be clean
  • If PR adds a configuration option, it must be added to the configuration file.

ofek
ofek approved these changes Feb 21, 2019
View reviewed changes
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

ofek
ofek requested changes Feb 21, 2019
View reviewed changes
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci failing

@trishankatdatadog
Copy link
Member Author

it just looks like a read timeout, 4s which might be too onerous

shall i make a separate PR for that?

@ofek
Copy link
Contributor

ofek commented Feb 21, 2019

Sure

@trishankatdatadog
Copy link
Member Author

Can we merge this for now? Thanks!

@trishankatdatadog
Copy link
Member Author

@ofek Please see related #3182.

@ofek ofek merged commit c85d3f6 into master Feb 21, 2019
@ofek ofek deleted the trishankatdatadog/improve-err-msg-when-check-not-found branch February 21, 2019 22:01
@zippolyte zippolyte changed the title Separate module for exceptions Move exceptions to their own submodule Feb 22, 2019
ofek pushed a commit that referenced this pull request Feb 22, 2019
@trishankatdatadog @ofek
Separate module for exceptions (#3180)
963f987 
* Better error message when no such DD package or version

* reduce number of lines

* cleaner, separate module for exceptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek ofek ofek requested changes

@zippolyte zippolyte Awaiting requested review from zippolyte

Assignees
No one assigned
Labels
integration/datadog_checks_downloader
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trishankatdatadog @ofek @zippolyte