Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message when no such DD package or version #3161

Merged

Conversation

trishankatdatadog
Copy link
Member

What does this PR do?

Friendlier error messages when no such DD package or version.

Motivation

In order to provide customers with a better idea of what went wrong in such a case.

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • Feature or bugfix must have tests
  • Git history must be clean
  • If PR adds a configuration option, it must be added to the configuration file.

@codecov
Copy link

codecov bot commented Feb 19, 2019

Codecov Report

Merging #3161 into master will increase coverage by 15.38%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #3161       +/-   ##
==========================================
+ Coverage   84.61%    100%   +15.38%     
==========================================
  Files         677       1      -676     
  Lines       36619      18    -36601     
  Branches     4319       2     -4317     
==========================================
- Hits        30984      18    -30966     
+ Misses       4373       0     -4373     
+ Partials     1262       0     -1262

@zippolyte zippolyte merged commit e6bd3b9 into master Feb 20, 2019
@zippolyte zippolyte deleted the trishankatdatadog/improve-err-msg-when-check-not-found branch February 20, 2019 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants