Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Cloudfront instead of direct-to-S3 #3087

Merged
merged 1 commit into from
Feb 11, 2019

Conversation

trishankatdatadog
Copy link
Member

What does this PR do?

Point our downloader to our Cloudfront distribution instead of our S3 bucket directly.

Motivation

Some customers have blacklisted amazonaws.com but not datadoghq.com on their firewalls. This should fix that issue.

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • If PR adds a configuration option, it has been added to the configuration file.

Additional Notes

Anything else we should know when reviewing?

@codecov
Copy link

codecov bot commented Feb 8, 2019

Codecov Report

Merging #3087 into master will increase coverage by 15.7%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #3087      +/-   ##
=========================================
+ Coverage   84.29%    100%   +15.7%     
=========================================
  Files         676       1     -675     
  Lines       37192      18   -37174     
  Branches     4431       2    -4429     
=========================================
- Hits        31350      18   -31332     
+ Misses       4570       0    -4570     
+ Partials     1272       0    -1272

@ofek ofek merged commit ada071e into master Feb 11, 2019
@ofek ofek deleted the trishankatdatadog/update-downloader-domain-name branch February 11, 2019 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration/datadog_checks_downloader kind/bug severity/minor Issues that do not affect the functionality of integrations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants