-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for SASL_PLAINTEXT authentication with Kafka broker #3056
Conversation
@PHameete Thanks for the PR. Tests are failing though, this is |
Codecov Report
@@ Coverage Diff @@
## master #3056 +/- ##
==========================================
- Coverage 84.03% 78.65% -5.38%
==========================================
Files 648 8 -640
Lines 36033 520 -35513
Branches 4352 110 -4242
==========================================
- Hits 30279 409 -29870
+ Misses 4482 79 -4403
+ Partials 1272 32 -1240 |
@dabcoder ty for getting back to me. I did the merge as requested. |
@PHameete Thanks a lot for this contribution. 💯 After looking at the client doc, it seems that we are missing quite a lot of config in there. Also, would you mind to format the config file based on this convention. @l0k0ms should be able to assist you there. |
@gzussa I've added all authentication parameters (SSL, SASL, Kerberos) that were missing on the datadog integration side, and example config according to the example you provided. It seems a bit overkill to add all the timeouts and buffer sizes. Regarding the sasl: I dont think they are global. |
@PHameete Thanks, and apologies for the delay, we are still looking into the |
@dabcoder not a problem, let me know if you need anything! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plop, many thanks for the PR. 🙇
Note for later @DataDog/baklava will need to do a refactoring of the configuration file once this PR is merged, there a lots of nits to update. Creating a card on our internal board to keep this under our radar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for your contribution 💯
What does this PR do?
Add support for SASL Plaintext authentication with the Kafka broker to the kafka_consumer integration. This uses properties already available on the used KafkaClient.
Motivation
It was currently only possible to use PLAINTEXT or SSL. This makes it possible to also connect to a Kafka broker using SASL_PLAINTEXT. The KafkaClient does not support SASL_SSL yet unfortunately.
Review checklist
no-changelog
label attached