Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3 #3035

Merged
merged 1 commit into from
Jan 25, 2019
Merged

Support Python 3 #3035

merged 1 commit into from
Jan 25, 2019

Conversation

nmuesch
Copy link
Collaborator

@nmuesch nmuesch commented Jan 25, 2019

What does this PR do?

Check mostly supported py3, just had to update some iteritems and use new imports.

Motivation

Support 🐍3️⃣

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • If PR adds a configuration option, it has been added to the configuration file.

Additional Notes

Anything else we should know when reviewing?

@codecov-io
Copy link

Codecov Report

Merging #3035 into master will decrease coverage by 32.87%.
The diff coverage is 69.23%.

@@             Coverage Diff             @@
##           master    #3035       +/-   ##
===========================================
- Coverage   84.23%   51.35%   -32.88%     
===========================================
  Files         666        5      -661     
  Lines       35945      923    -35022     
  Branches     4266      125     -4141     
===========================================
- Hits        30278      474    -29804     
+ Misses       4422      426     -3996     
+ Partials     1245       23     -1222

Copy link
Contributor

@gmmeyer gmmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow this looks great! nice job!

@nmuesch nmuesch merged commit 270f90d into master Jan 25, 2019
@nmuesch nmuesch deleted the nick/os3 branch January 25, 2019 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants