Support Python 3 #3028
Merged
Support Python 3 #3028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3028 +/- ##
==========================================
+ Coverage 84.15% 88.99% +4.83%
==========================================
Files 673 10 -663
Lines 36595 1145 -35450
Branches 4336 153 -4183
==========================================
- Hits 30798 1019 -29779
+ Misses 4548 85 -4463
+ Partials 1249 41 -1208 |
gmmeyer
approved these changes
Jan 24, 2019
| from datadog_checks.stubs import aggregator | ||
| aggregator.reset() | ||
| return aggregator | ||
| @pytest.fixture() |
There was a problem hiding this comment.
I meant to put this in the PR description, basically there is a bug in requests-mock where the decorator isn't registered as a fixture for pytest, and this only impacts PY3 - pytest-dev/pytest#2749
gmmeyer
suggested changes
Jan 24, 2019
kubelet/tests/test_cadvisor.py
Outdated
| aggregator.reset() | ||
| return aggregator | ||
| @pytest.fixture() | ||
| def m(): |
gmmeyer
previously approved these changes
Jan 24, 2019
xvello
previously approved these changes
Jan 25, 2019
ofek
approved these changes
Jan 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
New urlparse and urljoin import, division
Motivation
Support 🐍 3️⃣
Review checklist
no-changeloglabel attachedAdditional Notes
Anything else we should know when reviewing?