Support Python 3 #2964
Merged
Support Python 3 #2964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2964 +/- ##
==========================================
- Coverage 84.79% 76.52% -8.27%
==========================================
Files 654 4 -650
Lines 36319 115 -36204
Branches 4334 9 -4325
==========================================
- Hits 30795 88 -30707
+ Misses 4262 22 -4240
+ Partials 1262 5 -1257 |
zippolyte
requested changes
Jan 17, 2019
| import socket | ||
| import time | ||
|
|
||
| # project | ||
| from datadog_checks.base import ensure_unicode |
There was a problem hiding this comment.
this will require pinning base check to >= 4.2.0
| import socket | ||
| import time | ||
|
|
||
| # project | ||
| from datadog_checks.base import ensure_unicode | ||
| from datadog_checks.checks import NetworkCheck, Status |
There was a problem hiding this comment.
While you're pinning, let's import from the base submodule
zippolyte
approved these changes
Jan 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add python 3 support to tcp_check. Mostly was supported already, but required the name to be converted to unicode.
Motivation
🐍3️⃣
Review checklist
no-changeloglabel attachedAdditional Notes
Anything else we should know when reviewing?