Support Python 3 #2761
Merged
Support Python 3 #2761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2761 +/- ##
=========================================
+ Coverage 84.7% 90.9% +6.2%
=========================================
Files 651 7 -644
Lines 37215 165 -37050
Branches 4491 18 -4473
=========================================
- Hits 31524 150 -31374
+ Misses 4375 8 -4367
+ Partials 1316 7 -1309 |
ofek
requested changes
Dec 15, 2018
| "-e", | ||
| "CREATE KEYSPACE IF NOT EXISTS test WITH REPLICATION={'class':'SimpleStrategy', 'replication_factor':2}" | ||
| ]) | ||
| yield |
There was a problem hiding this comment.
Please clean all this up using our docker utils
ofek
approved these changes
Dec 15, 2018
|
Docker util updates coming in my next PR 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add support for Python3
Motivation
An effort to support Python3 for all integrations
Review checklist
no-changeloglabel attachedAdditional Notes