[kafka_consumer] Bump vendored kazoo to 2.6.0 #2729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bumps to 1.4.4 which added the new `KafkaAdminClient` which we need in order to make `monitor_unlisted_consumer_groups` work for consumer offsets stored in Kafka. It also comes in handy since it will let us remove a bunch of code from the existing `KafkaCheck` and just rely on upstream.
This fixes a number of issues, including handling backoff/jitter better: python-zk/kazoo#521
Codecov Report
@@ Coverage Diff @@
## master #2729 +/- ##
==========================================
- Coverage 84.64% 78.61% -6.04%
==========================================
Files 663 8 -655
Lines 37574 519 -37055
Branches 4518 110 -4408
==========================================
- Hits 31804 408 -31396
+ Misses 4433 79 -4354
+ Partials 1337 32 -1305 |
ofek
approved these changes
Dec 12, 2018
ofek
approved these changes
Dec 12, 2018
nmuesch
pushed a commit
that referenced
this pull request
Dec 14, 2018
* Bump kafka-python to 1.4.4 This bumps to 1.4.4 which added the new `KafkaAdminClient` which we need in order to make `monitor_unlisted_consumer_groups` work for consumer offsets stored in Kafka. It also comes in handy since it will let us remove a bunch of code from the existing `KafkaCheck` and just rely on upstream. * Bump vendored kazoo to 2.6.0 This fixes a number of issues, including handling backoff/jitter better: python-zk/kazoo#521
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a number of issues, including handling backoff/jitter better:
python-zk/kazoo#521
Note:
#2728 should be merged first, to avoid merge conflicts.