Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove KSM deprecated pod phase service checks #2631

Merged
merged 1 commit into from
Nov 23, 2018

Conversation

mfpierre
Copy link
Contributor

What does this PR do?

Remove pod phase service checks that were deprecated.

Motivation

Cleanup

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

Additional Notes

Anything else we should know when reviewing?

Copy link
Contributor

@xvello xvello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@codecov-io
Copy link

Codecov Report

Merging #2631 into master will decrease coverage by 1.91%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2631      +/-   ##
==========================================
- Coverage   83.88%   81.97%   -1.92%     
==========================================
  Files         644        4     -640     
  Lines       36453      355   -36098     
  Branches     4439       68    -4371     
==========================================
- Hits        30580      291   -30289     
+ Misses       4556       44    -4512     
+ Partials     1317       20    -1297

@mfpierre mfpierre merged commit a2baa78 into master Nov 23, 2018
@mfpierre mfpierre deleted the mfpierre/remove-ksm-pod-phase-service-check branch November 23, 2018 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants