Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker daemon doc update #2629

Merged
merged 2 commits into from
Nov 26, 2018
Merged

Docker daemon doc update #2629

merged 2 commits into from
Nov 26, 2018

Conversation

ruthnaebeck
Copy link
Contributor

@ruthnaebeck ruthnaebeck commented Nov 21, 2018 •
edited
Loading

What does this PR do?

  • Add note about docker.exit status check
  • Update wording / formatting

Motivation

Trello request from support

Preview

https://github.com/DataDog/integrations-core/blob/ruth/docker-exit-docs/docker_daemon/README.md

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
    [ ] Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

@ruthnaebeck ruthnaebeck self-assigned this Nov 21, 2018
@ruthnaebeck ruthnaebeck requested review from a team as code owners November 21, 2018 21:17
ofek
ofek approved these changes Nov 23, 2018
View reviewed changes
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ruthnaebeck ruthnaebeck merged commit 4478988 into master Nov 26, 2018
@ruthnaebeck ruthnaebeck deleted the ruth/docker-exit-docs branch November 26, 2018 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek ofek ofek approved these changes

Assignees

@ruthnaebeck ruthnaebeck

Labels
changelog/no-changelog documentation integration/docker_daemon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruthnaebeck @ofek