Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send service check as metric #2509

Merged
merged 4 commits into from
Nov 6, 2018
Merged

Send service check as metric #2509

merged 4 commits into from
Nov 6, 2018

Conversation

zippolyte
Copy link
Contributor

@zippolyte zippolyte commented Nov 6, 2018

What does this PR do?

Send the service check as a metric as well: 1 for up status, 0 for others

Motivation

FR

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

Additional Notes

Also 🔥 some ruby leftovers

Copy link
Collaborator

@nmuesch nmuesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me thanks! Can you add the new metric to the metadata.csv file?

@codecov-io
Copy link

Codecov Report

Merging #2509 into master will decrease coverage by 8.26%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2509      +/-   ##
==========================================
- Coverage   84.57%   76.31%   -8.27%     
==========================================
  Files         631        4     -627     
  Lines       35398      114   -35284     
  Branches     4302        9    -4293     
==========================================
- Hits        29939       87   -29852     
+ Misses       4168       22    -4146     
+ Partials     1291        5    -1286

@zippolyte zippolyte merged commit e27d72a into master Nov 6, 2018
@zippolyte zippolyte deleted the hippo/tcp_metric branch November 6, 2018 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants