Fix hostname override and type for status_report.count metrics #2372
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The hostname of the
.container.status_report.count.waiting
and.container.status_report.count.terminated
metrics was not extracted from the label join map.Add the
OpenMetricsScraperMixin.get_hostname_for_sample
public method to expose the information to checks, and use it for these two metrics.Also, set the metric type as
gauge
, ascount
bring erroneous values (counted by the app as the number ofcount
calls per minutes, instead of per check run). As the timeseries are container cardinality (pod
andkube_container_name
tags), no client-side aggregation is needed for gauges.Motivation
What inspired you to submit this pull request?
Review checklist
no-changelog
label attachedAdditional Notes
Anything else we should know when reviewing?