-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix KSM deprecation warning on A5 #2317
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2317 +/- ##
==========================================
- Coverage 85.83% 82.62% -3.22%
==========================================
Files 188 4 -184
Lines 12676 374 -12302
Branches 1324 72 -1252
==========================================
- Hits 10881 309 -10572
+ Misses 1410 44 -1366
+ Partials 385 21 -364
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
"`send_pod_phase_service_checks` to false and rely on corresponding gauges instead", | ||
] | ||
if self.send_pod_phase_service_checks: | ||
self.warning("DEPRECATION NOTICE: pod phase service checks are deprecated. Please set " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Calling instance methods like warning
in the __init__
could be risky if the object weren't properly initialized... However at this stage, after the super()
, this doesn't look too harmful to me. Also, the constructor is unlikely to fail after the warning.
What does this PR do?
Fix the use of a deprecation method only compatible with A6
Motivation
Make the KSM check work again on A5
Review checklist
no-changelog
label attachedAdditional Notes
Is it ok to call
self.warning
in the init function?