Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional kubelet metrics #2245

Merged
merged 1 commit into from
Sep 18, 2018
Merged

Conversation

mfpierre
Copy link
Contributor

Add additional kubelet metrics:

  • kubelet client request latency in seconds
  • network plugin operation latency in microseconds

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

Additional Notes

Anything else we should know when reviewing?

* kubelet client request latency in seconds
* network plugin operation latency in microseconds
@mfpierre mfpierre force-pushed the mfpierre/add-kubelet-metrics branch from 4e10d66 to 8c2d45a Compare September 17, 2018 09:26
@codecov-io
Copy link

Codecov Report

Merging #2245 into master will increase coverage by 0.29%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2245      +/-   ##
==========================================
+ Coverage   86.59%   86.88%   +0.29%     
==========================================
  Files         191        8     -183     
  Lines       13309      839   -12470     
  Branches     1388      129    -1259     
==========================================
- Hits        11525      729   -10796     
+ Misses       1397       78    -1319     
+ Partials      387       32     -355

Copy link
Contributor

@xvello xvello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@gzussa gzussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mfpierre mfpierre merged commit 6583f87 into master Sep 18, 2018
@mfpierre mfpierre deleted the mfpierre/add-kubelet-metrics branch September 18, 2018 16:37
nmuesch pushed a commit that referenced this pull request Nov 1, 2018
* kubelet client request latency in seconds
* network plugin operation latency in microseconds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants