Include ContainerCreating in pod waiting status reasons #2063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've seen different issues where the container can get stuck in the ContainerCreating status without moving to any of the other listed waiting reasons. For example, a bug in [amazon-vpc-cni-k8s][1] can cause a pod to get stuck in that status if the CNI plugin is unable to assign an IP for the pod. Whitelisting this status allows monitoring for these cases. With this reason added to the list, the list now contains all the [possible reasons][2] and is therefore unnecessary barring future addition of reasons. If it were up to me, I'd simply drop the whitelist check, but there seems to be [some opposition][3] to that. [1]: https://github.com/aws/amazon-vpc-cni-k8s [2]: https://github.com/kubernetes/kube-state-metrics/blob/bcb230560fe1a32810577762f0b91ad0a5f50d1a/Documentation/pod-metrics.md [3]: #1763 (comment)
|
We also have containers become hung in the Is someone from DataDog able to review and merge this? |
|
Please, it's a simple change. |
CharlyF
approved these changes
Sep 19, 2018
masci
approved these changes
Sep 19, 2018
|
Thank you! |
nmuesch
pushed a commit
that referenced
this pull request
Nov 1, 2018
Include ContainerCreating in pod waiting status reasons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
ContainerCreatingto the list of whitelisted pod waiting statuses.Motivation
I've seen different issues where the container can get stuck in the ContainerCreating status without moving to any of the other listed waiting reasons. For example, a bug in amazon-vpc-cni-k8s can cause a pod to get stuck in that status if the CNI plugin is unable to assign an IP for the pod. Whitelisting this status allows monitoring for these cases.
Review checklist
no-changeloglabel attachedAdditional Notes
I originally raised the question of whitelisting this status in another PR.
With this reason added to the list, the list now contains all the possible reasons and is therefore unnecessary barring future addition of reasons. If it were up to me, I'd simply drop the whitelist check, but there seems to be some opposition to that.