Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused code #19701

Merged
merged 2 commits into from
Feb 24, 2025
Merged

remove unused code #19701

merged 2 commits into from
Feb 24, 2025

Conversation

sarah-witt
Copy link
Contributor

@sarah-witt sarah-witt commented Feb 24, 2025

What does this PR do?

Removes unused code

Motivation

I found this while reviewing the permissions flow

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.42%. Comparing base (dcb1e53) to head (3a411dd).
Report is 2 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
openstack_controller 94.65% <ø> (?)
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@sarah-witt sarah-witt marked this pull request as ready for review February 24, 2025 20:23
@sarah-witt sarah-witt requested a review from a team as a code owner February 24, 2025 20:23
@sarah-witt sarah-witt added this pull request to the merge queue Feb 24, 2025
Merged via the queue into master with commit 85b3267 Feb 24, 2025
42 checks passed
@sarah-witt sarah-witt deleted the sarah/remove-unused-code branch February 24, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants