-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AI-4929] [LOI-381] Add logs for octopus_deploy #19543
Conversation
…og/integrations-core into sarah/add-logs-integration-octopus
Logs files configs looks to me. I have pushed the integration to our staging environment, feel free to test there.
I am not super clear about your explanation here? Deploy logs are catch here and will be parsed by the grok parser? I am a bit curious as well, it could still be useful to have an integration for server logs? If you want to setup properly the timestamp used for logs, or other info? |
The integration is available in our staging environment, I let you confirm this is working as intended for you 👍 |
Co-authored-by: Thibault Krebs <150821137+thibaultkrebs@users.noreply.github.com>
Thanks @thibaultkrebs, I tested on staging and confirmed the pipeline is working! |
…og/integrations-core into sarah/add-logs-integration-octopus
Review from drichards-87 is dismissed.
Related teams and files:
- documentation
- octopus_deploy/assets/configuration/spec.yaml
- octopus_deploy/datadog_checks/octopus_deploy/data/conf.yaml.example
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good for me
What does this PR do?
Add logs integration for octopus deploy
Motivation
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged