Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AI-4929] [LOI-381] Add logs for octopus_deploy #19543

Merged
merged 12 commits into from
Feb 21, 2025

Conversation

sarah-witt
Copy link
Contributor

@sarah-witt sarah-witt commented Feb 3, 2025

What does this PR do?

Add logs integration for octopus deploy

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@sarah-witt sarah-witt changed the title Add logs Add logs for octopus_deploy Feb 3, 2025
@sarah-witt sarah-witt changed the title Add logs for octopus_deploy [AI-4929] [LOI-381] Add logs for octopus_deploy Feb 4, 2025
@sarah-witt sarah-witt marked this pull request as ready for review February 4, 2025 19:38
@sarah-witt sarah-witt requested review from a team as code owners February 4, 2025 19:38
drichards-87
drichards-87 previously approved these changes Feb 4, 2025
@thibaultkrebs thibaultkrebs added the assets/deploy-logs-staging ONLY USED BY Logs Backend - Validates that a PR is OK to go to staging label Feb 11, 2025
@thibaultkrebs
Copy link
Contributor

Logs files configs looks to me. I have pushed the integration to our staging environment, feel free to test there.

The deploy logs will need no parsing since they are generated by the integration, but the server logs will. 

I am not super clear about your explanation here? Deploy logs are catch here and will be parsed by the grok parser?

I am a bit curious as well, it could still be useful to have an integration for server logs? If you want to setup properly the timestamp used for logs, or other info?

@thibaultkrebs
Copy link
Contributor

The integration is available in our staging environment, I let you confirm this is working as intended for you 👍

Co-authored-by: Thibault Krebs <150821137+thibaultkrebs@users.noreply.github.com>
@sarah-witt
Copy link
Contributor Author

Thanks @thibaultkrebs, I tested on staging and confirmed the pipeline is working!

@temporal-github-worker-1 temporal-github-worker-1 bot dismissed drichards-87’s stale review February 14, 2025 21:41

Review from drichards-87 is dismissed.
Related teams and files:

  • documentation
    • octopus_deploy/assets/configuration/spec.yaml
    • octopus_deploy/datadog_checks/octopus_deploy/data/conf.yaml.example
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.94%. Comparing base (487ed41) to head (fd6696e).
Report is 104 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
ignite ?
jboss_wildfly ?
kafka ?
octopus_deploy 99.25% <ø> (-0.01%) ⬇️
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@thibaultkrebs thibaultkrebs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for me

@sarah-witt sarah-witt added this pull request to the merge queue Feb 21, 2025
Merged via the queue into master with commit 679238b Feb 21, 2025
35 checks passed
@sarah-witt sarah-witt deleted the sarah/add-logs-integration-octopus branch February 21, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets/deploy-logs-staging ONLY USED BY Logs Backend - Validates that a PR is OK to go to staging documentation integration/octopus_deploy team/agent-integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants