Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regex values in configuration example #19453

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

ddalexvea
Copy link
Contributor

The values istio_* and envoy_* make less sense in regex because it will match this (https://regex101.com/r/ehe8T9/1). The best regex values would be istio_.* and envoy_.*

What does this PR do?

It will change values of the exclude_metrics parameters for the openmetric latest mode, in the configuration example.

Motivation

The values istio_* and envoy_* make less sense in regex because it will match this (https://regex101.com/r/ehe8T9/1). The best regex values would be istio_.* and envoy_.*

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

The values istio_* and envoy_* make less sense in regex because it will match this (https://regex101.com/r/ehe8T9/1).
The best regex values would be  istio_.* and envoy_.*
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.33%. Comparing base (71264b6) to head (b4d7be4).
Report is 12 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@ddalexvea
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 23, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-23 08:18:58 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-01-23 12:19:06 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@Kyle-Neale Kyle-Neale added this pull request to the merge queue Feb 25, 2025
Merged via the queue into master with commit c36f1ff Feb 25, 2025
46 of 47 checks passed
@Kyle-Neale Kyle-Neale deleted the alexandre.vea/fix-regex-conf-example branch February 25, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants