-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix regex values in configuration example #19453
Conversation
The values istio_* and envoy_* make less sense in regex because it will match this (https://regex101.com/r/ehe8T9/1). The best regex values would be istio_.* and envoy_.*
/merge |
Devflow running:
|
The values istio_* and envoy_* make less sense in regex because it will match this (https://regex101.com/r/ehe8T9/1). The best regex values would be istio_.* and envoy_.*
What does this PR do?
It will change values of the exclude_metrics parameters for the openmetric latest mode, in the configuration example.
Motivation
The values istio_* and envoy_* make less sense in regex because it will match this (https://regex101.com/r/ehe8T9/1). The best regex values would be istio_.* and envoy_.*
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged