Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure all checks' versions are exposed #1945

Merged
merged 1 commit into from
Jul 26, 2018
Merged

Make sure all checks' versions are exposed #1945

merged 1 commit into from
Jul 26, 2018

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Jul 26, 2018

Motivation

Agent couldn't find some

@ofek ofek requested a review from a team as a code owner July 26, 2018 16:52
gmmeyer
gmmeyer approved these changes Jul 26, 2018
View reviewed changes
Copy link
Contributor

@gmmeyer gmmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gzussa
Copy link
Contributor

gzussa commented Jul 26, 2018

Should we create a check in ddev?

@ofek ofek merged commit 1cd80c8 into master Jul 26, 2018
@ofek ofek deleted the ofek/version branch July 26, 2018 17:09
ofek added a commit that referenced this pull request Jul 26, 2018
@ofek
Make sure all checks' versions are exposed (#1945)
f64a941
@gmmeyer
Copy link
Contributor

gmmeyer commented Jul 26, 2018

@gzussa good idea put it in the backlog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmmeyer gmmeyer gmmeyer approved these changes

Assignees
No one assigned
Labels
integration/apache integration/couch integration/haproxy integration/kube_proxy integration/mysql integration/powerdns_recursor integration/teamcity integration/varnish
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ofek @gzussa @gmmeyer