Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix octopus fixture paths on windows #19434

Merged
merged 6 commits into from
Jan 17, 2025
Merged

Conversation

sarah-witt
Copy link
Contributor

@sarah-witt sarah-witt commented Jan 17, 2025

What does this PR do?

fixes fixture paths so they are compatible with windows filesystems

Motivation

breaking windows builds

Notes

validation fix is here: #19432

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.84%. Comparing base (33a15dd) to head (adb0859).
Report is 4 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
confluent_platform ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
octopus_deploy 99.16% <100.00%> (?)
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@sarah-witt sarah-witt marked this pull request as ready for review January 17, 2025 19:45
@sarah-witt sarah-witt requested review from a team as code owners January 17, 2025 19:45
@sarah-witt sarah-witt added this pull request to the merge queue Jan 17, 2025
Merged via the queue into master with commit 6782bb7 Jan 17, 2025
31 of 32 checks passed
@sarah-witt sarah-witt deleted the sarah/fix-paths-windows branch January 17, 2025 20:32
@sarah-witt sarah-witt mentioned this pull request Jan 17, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants