Add support for target_info metric w/ shared label cache #19397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
…g/integrations-core into UTXOnly/openmetrics-target-info-4
|
is it possible to have more than 1 target_info entry? Or would there always be 1 only per payload? |
steveny91
reviewed
Feb 3, 2025
datadog_checks_base/tests/base/checks/openmetrics/test_v2/test_options.py
Outdated
Show resolved
Hide resolved
steveny91
previously approved these changes
Feb 3, 2025
…_options.py Co-authored-by: Steven Yuen <steven.yuen@datadoghq.com>
Review from steveny91 is dismissed.
Related teams and files:
- agent-integrations
- datadog_checks_base/tests/base/checks/openmetrics/test_v2/test_options.py
Kyle-Neale
approved these changes
Feb 18, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Feb 18, 2025
* Collect target info metric * Corrected cache error * Log cleanup * Debug log cleanup * Add tests to test cache w/ target_info * Add test for unordered target info with cache shared labels * Add transformer for info metric type * Cleaned but not working first iteration * Refactor tag caching logic * Validate type for config options * Added changelog entry * Fix validate shared labels failing test * Fix whitespace causing lint failure * Fix target info with cache, add tests * Linting * Cleanup debug log * Comment cleanup * Refactor label population * Reformat imports * Reorder target_info_labels definition * Add consume w/ target info method * Add comments * Update datadog_checks_base/tests/base/checks/openmetrics/test_v2/test_options.py Co-authored-by: Steven Yuen <steven.yuen@datadoghq.com> * lint test --------- Co-authored-by: Steven Yuen <steven.yuen@datadoghq.com> d802c07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
target_infotypeMotivation
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged