Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integrations-core builder $PYTHON_VERSION warnings #19374

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

Kyle-Neale
Copy link
Contributor

What does this PR do?

This PR fixes integrations-core builder PYTHON_VERSION warnings

Motivation

 1 warning found (use docker --debug to expand):
 - UndefinedVar: Usage of undefined variable '$PYTHON_VERSION' (did you mean $PYTHON3_VERSION?) (line 50)

https://github.com/DataDog/integrations-core/actions/runs/12716427655/job/35450751933?pr=19372#step:10:26669

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@Kyle-Neale Kyle-Neale force-pushed the kyle.neale/fix-builder-python-warnings branch from f31b68c to 86958d6 Compare January 10, 2025 21:51
@Kyle-Neale Kyle-Neale marked this pull request as ready for review January 10, 2025 22:14
@Kyle-Neale Kyle-Neale requested review from a team as code owners January 10, 2025 22:14
@Kyle-Neale Kyle-Neale changed the title Fix integrations-core builder PYTHON_VERSION warnings Fix integrations-core builder $PYTHON_VERSION warnings Jan 13, 2025
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.58%. Comparing base (fd0bf69) to head (86958d6).
Report is 12 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@Kyle-Neale Kyle-Neale added this pull request to the merge queue Jan 13, 2025
Merged via the queue into master with commit faf3717 Jan 13, 2025
40 checks passed
@Kyle-Neale Kyle-Neale deleted the kyle.neale/fix-builder-python-warnings branch January 13, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants