Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SAASINT-3459] DDSaaS: Blazemeter: Crawler Integration v1.0.0 #19346

Merged
merged 23 commits into from
Feb 27, 2025

Conversation

bparmar-crest
Copy link
Contributor

What does this PR do?

This is a initial release PR of BlazeMeter integration including all the required assets.

Motivation

Crawler code for this integration has been committed in its respective repo.
The assets are available in our sandbox and can be shared separately with the required teams.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@torosmassa torosmassa changed the title DDSaaS: Blazemeter: Crawler Integration v1.0.0 [SAASINT-3459] DDSaaS: Blazemeter: Crawler Integration v1.0.0 Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.63%. Comparing base (f3966d5) to head (2be5f47).
Report is 3 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
duckdb ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
supabase ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@torosmassa torosmassa changed the title [SAASINT-3459] DDSaaS: Blazemeter: Crawler Integration v1.0.0 DDSaaS: Blazemeter: Crawler Integration v1.0.0 Jan 8, 2025
@torosmassa torosmassa changed the title DDSaaS: Blazemeter: Crawler Integration v1.0.0 [SAASINT-3459] DDSaaS: Blazemeter: Crawler Integration v1.0.0 Jan 8, 2025
@torosmassa torosmassa changed the title [SAASINT-3459] DDSaaS: Blazemeter: Crawler Integration v1.0.0 DDSaaS: Blazemeter: Crawler Integration v1.0.0 Jan 8, 2025
@torosmassa torosmassa marked this pull request as ready for review February 5, 2025 12:31
@torosmassa torosmassa requested review from a team as code owners February 5, 2025 12:31
@temporal-github-worker-1 temporal-github-worker-1 bot dismissed drichards-87’s stale review February 6, 2025 10:03

Review from drichards-87 is dismissed.
Related teams and files:

  • documentation
    • blazemeter/README.md
@gunterd
Copy link
Contributor

gunterd commented Feb 11, 2025

@dpoint01 Tagging for your review

gunterd
gunterd previously approved these changes Feb 20, 2025
Kyle-Neale
Kyle-Neale previously approved these changes Feb 20, 2025
"media_type": "image"
},
{
"caption": "BlazeMeter - Performance Test Results",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need multiple images for the dashboards. We can do one image for each dashboard.

On that note, do we have an overview dashboard combining the overview of the 3 dashboards here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dpoint01 Sure we will reduce the images for each dashboards to two because single image does not cover few things.
Also, we do not have a separate dashboard for Overview.

Please let us know your thoughts.

@temporal-github-worker-1 temporal-github-worker-1 bot dismissed stale reviews from gunterd and Kyle-Neale February 24, 2025 04:14

Review from gunterd is dismissed.
Related teams and files:

  • saas-integrations
    • .github/CODEOWNERS
      Review from Kyle-Neale is dismissed.
      Related teams and files:
  • agent-integrations
    • .github/CODEOWNERS
@gunterd gunterd added this pull request to the merge queue Feb 27, 2025
Merged via the queue into DataDog:master with commit 9c80b4c Feb 27, 2025
43 of 45 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 27, 2025
* BlazeMeter without assets

* blazemeter.svg added

* classifier tags updated

* classifier tags updated

* README changes

* Changes reverted CODEOWNERS

* added assets, images and modified manifest and metadata files

* sorted metadata.csv and modified monitors

* modified metadata.csv

* Check field added in manifest.json

* Dashboard title modified with snapshot

* added units in Dashboard panels

* modified readme and metadata files

* Manifest.json changed.

---------

Co-authored-by: Raj Shah <raj.shah@crestdata.ai> 9c80b4c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants