Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permissions to the test-results-master and test-results-pr workflows in GitHub Actions #19103

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

nubtron
Copy link
Contributor

@nubtron nubtron commented Nov 21, 2024

What does this PR do?

Add permissions for the EnricoMi/publish-unit-test-result-action@v2 and the emibcn/badge-action@v2.0.3 actions. They will be needed when we set default workflow permissions to read-only for the repo.

For the GitHub Action to Publish Test Results, the required permissions are documented.
For for Badge action, I ran an experiment to see which permissions are needed.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@nubtron
Copy link
Contributor Author

nubtron commented Nov 21, 2024

@HadhemiDD thank you for the review!

@nubtron nubtron added this pull request to the merge queue Nov 21, 2024
Merged via the queue into master with commit 61a4810 Nov 21, 2024
56 of 58 checks passed
@nubtron nubtron deleted the nubtron/publish-test-results-permissions branch November 21, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants