Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CONTP-382] Add Validation Webhook telemetry metrics #18867

Merged
merged 2 commits into from
Oct 18, 2024
Merged

[CONTP-382] Add Validation Webhook telemetry metrics #18867

merged 2 commits into from
Oct 18, 2024

Conversation

gabedos
Copy link
Contributor

@gabedos gabedos commented Oct 17, 2024 •
edited
Loading

What does this PR do?

Adds telemetry for new Validating Admission Controller.

Motivation

Maintain visibility of new feature status.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@gabedos gabedos force-pushed the gabedos/validation-admission-controller-metrics branch from 1e4d2e2 to 193fd98 Compare October 17, 2024 17:09
@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@codecov Codecov
Copy link

codecov bot commented Oct 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.88%. Comparing base (c8ba87f) to head (59acd3c).
Report is 2 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
datadog_cluster_agent 90.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@gabedos gabedos force-pushed the gabedos/validation-admission-controller-metrics branch from 193fd98 to 7ba3489 Compare October 17, 2024 17:43
@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@gabedos gabedos force-pushed the gabedos/validation-admission-controller-metrics branch from 7ba3489 to 9b7c094 Compare October 17, 2024 18:28
@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@gabedos gabedos force-pushed the gabedos/validation-admission-controller-metrics branch from 9b7c094 to 4227a0e Compare October 17, 2024 18:45
@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@gabedos gabedos force-pushed the gabedos/validation-admission-controller-metrics branch 3 times, most recently from 1015833 to bd89f75 Compare October 17, 2024 20:04
@gabedos gabedos changed the title [CONTP-382] Add scraping for new validation_attempts metrics [CONTP-382] Add Validation Webhook telemetry metrics Oct 17, 2024
@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@gabedos gabedos force-pushed the gabedos/validation-admission-controller-metrics branch from bd89f75 to 59acd3c Compare October 17, 2024 20:27
@gabedos gabedos marked this pull request as ready for review October 17, 2024 20:33
@gabedos gabedos requested review from a team as code owners October 17, 2024 20:33
jennchenn
jennchenn previously approved these changes Oct 17, 2024
View reviewed changes
datadog_cluster_agent/metadata.csv Outdated Show resolved Hide resolved
steveny91
steveny91 previously approved these changes Oct 17, 2024
View reviewed changes
@gabedos gabedos dismissed stale reviews from steveny91 and jennchenn via f334a99 October 18, 2024 15:34
@gabedos gabedos added this pull request to the merge queue Oct 18, 2024
Merged via the queue into master with commit 67be2b5 Oct 18, 2024
43 of 44 checks passed
@gabedos gabedos deleted the gabedos/validation-admission-controller-metrics branch October 18, 2024 17:24
lu-zhengda pushed a commit that referenced this pull request Oct 20, 2024
@gabedos @lu-zhengda
[CONTP-382] Add Validation Webhook telemetry metrics (#18867)
f929f0a 
* Add Validation Webhook telemetry

* Updating webhooks_receieved description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennchenn jennchenn jennchenn approved these changes

@steveny91 steveny91 steveny91 left review comments

Assignees
No one assigned
Labels
agent/review-requested docs/review-requested documentation ecosystems/review-requested integration/datadog_cluster_agent product/review-requested qa/skip-qa Automatically skip this PR for the next QA team/agent-integrations team/container-integrations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabedos @steveny91 @jennchenn