Add pod: tags to kubernetes_state status reason metrics
#1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdecat
reviewed
Jul 18, 2018
| @@ -383,6 +383,8 @@ def kube_pod_container_status_waiting_reason(self, message, **kwargs): | |||
| tags.append(self._format_tag("kube_container_name", label.value)) | |||
| elif label.name == "namespace": | |||
| tags.append(self._format_tag(label.name, label.value)) | |||
| elif label.name == "pod": | |||
There was a problem hiding this comment.
I guess kube_pod_container_status_waiting_reason() and kube_pod_container_status_terminated_reason() could use some refactoring to avoid so much duplicated code between them as only the metric name and whitelist differ from one to the other.
There was a problem hiding this comment.
yup, makes sense! Looks better now
mfpierre
previously approved these changes
Jul 20, 2018
added 4 commits
August 21, 2018 17:37
d59322f to
8618f60
Compare
gzussa
approved these changes
Aug 22, 2018
|
Thanks! Can you confirm which datadog-agent release will get this new feature? Note: the actual metrics are named |
nmuesch
pushed a commit
that referenced
this pull request
Nov 1, 2018
* Adding pod tags to kube_pod_container_status_waiting_reason and kube_pod_container_status_terminated_reason metrics * Refactoring metric logic for the two state reason metrics * fix line lengths * Adding comment regarding reason whitelist for cardinality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adding pod tags to
kube_pod_container_status_waiting_reasonandkube_pod_container_status_terminated_reasonmetricsMotivation
Github issue #1418
Review checklist
no-changeloglabel attached