Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 7.59.x] Fix tcp.current_established/tcp.connections metric types #18769

Merged
merged 1 commit into from
Oct 4, 2024
Merged

[Backport 7.59.x] Fix tcp.current_established/tcp.connections metric types #18769

merged 1 commit into from
Oct 4, 2024

Conversation

datadog-agent-integrations-bot[bot]
Copy link
Contributor

Backport 990cc9b from #18764.

What does this PR do?

Send tcp.current_established/tcp.connections as gauge instead of rate/count

adds tests for metric types

Motivation

https://datadoghq.atlassian.net/browse/WINA-1086
metrics added in #18294 but this case was missed

Additional Notes

no changelog b/c it's a fix for something not yet released (to be released in 7.58

this bug creates INFO logs of the form

No value returned for check metric 'system.net.tcp.connections' on host 'WIN-N52UFIFM9PJ' and tags '': Rate value is negative, discarding it (the underlying counter may have been reset)

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@datadog-agent-integrations-bot datadog-agent-integrations-bot bot requested a review from a team as a code owner October 4, 2024 14:29
@datadog-agent-integrations-bot datadog-agent-integrations-bot bot requested a review from a team as a code owner October 4, 2024 14:29
@codecov Codecov
Copy link

codecov bot commented Oct 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (7.59.x@8146155). Learn more about missing BASE report.

Additional details and impacted files
Flag Coverage Δ
network 93.51% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Kyle-Neale
Kyle-Neale previously approved these changes Oct 4, 2024
View reviewed changes
@Kyle-Neale Kyle-Neale changed the base branch from 7.59.x to release-existing-ints October 4, 2024 15:53
@Kyle-Neale Kyle-Neale changed the base branch from release-existing-ints to 7.59.x October 4, 2024 15:55
@Kyle-Neale Kyle-Neale dismissed their stale review October 4, 2024 15:55

The base branch was changed.

@Kyle-Neale Kyle-Neale merged commit c6513be into 7.59.x Oct 4, 2024
54 checks passed
@Kyle-Neale Kyle-Neale deleted the backport-18764-to-7.59.x branch October 4, 2024 15:56
HadhemiDD pushed a commit that referenced this pull request Oct 7, 2024
@datadog-agent-integrations-bot @clarkb7 @HadhemiDD
Fix tcp.current_established/tcp.connections metric types (#18764) (#1…
fbad6b0 
…8769)

(cherry picked from commit 990cc9b)

Co-authored-by: Branden Clark <branden.clark@datadoghq.com>
Kyle-Neale added a commit that referenced this pull request Oct 8, 2024
@HadhemiDD @iliakur
@datadog-agent-integrations-bot @clarkb7 @Kyle-Neale @neko-dd
Port existent integrations for 7.59.0 (#18795)
501c0e4 
* Release new integrations for 7.59.0 (#18767)

* [Release] Bumped appgate_sdp version to 1.0.0

* [Release] Bumped kubeflow version to 1.0.0

* [Release] Bumped kubevirt_api version to 1.0.0

* [Release] Bumped kubevirt_controller version to 1.0.0

* [Release] Bumped kubevirt_handler version to 1.0.0

* [Release] Update metadata

* Fix tcp.current_established/tcp.connections metric types (#18764) (#18769)

(cherry picked from commit 990cc9b)

Co-authored-by: Branden Clark <branden.clark@datadoghq.com>

* Release existing integrations for 7.59 (#18771)

* [Release] Bumped active_directory version to 4.0.0

* [Release] Bumped activemq version to 5.0.0

* [Release] Bumped activemq_xml version to 5.0.0

* [Release] Bumped aerospike version to 4.0.0

* [Release] Bumped airflow version to 6.1.0

* [Release] Bumped amazon_msk version to 6.0.0

* [Release] Bumped ambari version to 6.0.0

* [Release] Bumped apache version to 6.0.0

* [Release] Bumped arangodb version to 3.1.0

* [Release] Bumped argo_rollouts version to 2.1.0

* [Release] Bumped argo_workflows version to 2.1.0

* [Release] Bumped argocd version to 3.1.0

* [Release] Bumped aspdotnet version to 4.0.0

* [Release] Bumped avi_vantage version to 5.1.0

* [Release] Bumped aws_neuron version to 2.0.1

* [Release] Bumped azure_iot_edge version to 6.0.0

* [Release] Bumped boundary version to 3.1.0

* [Release] Bumped btrfs version to 4.0.0

* [Release] Bumped cacti version to 4.0.0

* [Release] Bumped calico version to 4.0.0

* [Release] Bumped cassandra version to 3.0.0

* [Release] Bumped cassandra_nodetool version to 3.0.0

* [Release] Bumped ceph version to 4.0.0

* [Release] Bumped cert_manager version to 5.1.0

* [Release] Bumped cilium version to 5.0.0

* [Release] Bumped cisco_aci version to 4.0.0

* [Release] Bumped citrix_hypervisor version to 5.0.0

* [Release] Bumped clickhouse version to 5.0.0

* [Release] Bumped cloud_foundry_api version to 5.0.0

* [Release] Bumped cloudera version to 3.1.0

* [Release] Bumped cockroachdb version to 5.0.0

* [Release] Bumped confluent_platform version to 3.0.0

* [Release] Bumped consul version to 4.0.0

* [Release] Bumped coredns version to 5.0.0

* [Release] Bumped couch version to 8.0.0

* [Release] Bumped couchbase version to 5.0.0

* [Release] Bumped crio version to 4.0.0

* [Release] Bumped datadog_checks_base version to 37.1.0

* [Release] Bumped datadog_checks_dependency_provider version to 3.0.0

* [Release] Bumped datadog_checks_downloader version to 6.0.0

* [Release] Bumped datadog_cluster_agent version to 5.0.0

* [Release] Bumped dcgm version to 3.1.0

* [Release] Bumped directory version to 4.0.0

* [Release] Bumped disk version to 7.0.0

* [Release] Bumped dns_check version to 5.0.0

* [Release] Bumped dotnetclr version to 4.0.0

* [Release] Bumped druid version to 4.0.0

* [Release] Bumped ecs_fargate version to 6.0.0

* [Release] Bumped eks_fargate version to 6.0.0

* [Release] Bumped elastic version to 8.0.0

* [Release] Bumped envoy version to 5.0.0

* [Release] Bumped esxi version to 3.0.0

* [Release] Bumped etcd version to 8.0.0

* [Release] Bumped exchange_server version to 4.0.0

* [Release] Bumped external_dns version to 5.0.0

* [Release] Bumped flink version to 3.0.0

* [Release] Bumped fluentd version to 5.0.0

* [Release] Bumped fluxcd version to 2.1.0

* [Release] Bumped fly_io version to 2.0.1

* [Release] Bumped foundationdb version to 3.0.0

* [Release] Bumped gearmand version to 5.0.0

* [Release] Bumped gitlab version to 9.0.0

* [Release] Bumped gitlab_runner version to 6.0.0

* [Release] Bumped glusterfs version to 3.0.0

* [Release] Bumped go_expvar version to 4.0.0

* [Release] Bumped gunicorn version to 4.0.0

* [Release] Bumped haproxy version to 7.0.0

* [Release] Bumped harbor version to 5.0.0

* [Release] Bumped hazelcast version to 6.0.0

* [Release] Bumped hdfs_datanode version to 6.0.0

* [Release] Bumped hdfs_namenode version to 6.0.0

* [Release] Bumped hive version to 2.1.0

* [Release] Bumped hivemq version to 2.1.0

* [Release] Bumped http_check version to 11.0.0

* [Release] Bumped hudi version to 4.0.0

* [Release] Bumped hyperv version to 3.0.0

* [Release] Bumped ibm_ace version to 4.0.0

* [Release] Bumped ibm_db2 version to 4.0.0

* [Release] Bumped ibm_i version to 4.0.0

* [Release] Bumped ibm_mq version to 8.0.0

* [Release] Bumped ibm_was version to 5.0.0

* [Release] Bumped ignite version to 3.1.0

* [Release] Bumped iis version to 5.0.0

* [Release] Bumped impala version to 3.1.0

* [Release] Bumped istio version to 8.0.0

* [Release] Bumped jboss_wildfly version to 3.1.0

* [Release] Bumped journald version to 3.0.0

* [Release] Bumped kafka version to 4.0.0

* [Release] Bumped kafka_consumer version to 6.0.0

* [Release] Bumped karpenter version to 2.1.0

* [Release] Bumped kong version to 5.0.0

* [Release] Bumped kube_apiserver_metrics version to 6.0.0

* [Release] Bumped kube_controller_manager version to 7.0.0

* [Release] Bumped kube_dns version to 6.0.0

* [Release] Bumped kube_metrics_server version to 5.0.0

* [Release] Bumped kube_proxy version to 8.0.0

* [Release] Bumped kube_scheduler version to 6.0.0

* [Release] Bumped kubelet version to 9.0.0

* [Release] Bumped kubernetes_cluster_autoscaler version to 2.1.0

* [Release] Bumped kubernetes_state version to 10.0.0

* [Release] Bumped kyototycoon version to 4.0.0

* [Release] Bumped kyverno version to 2.1.0

* [Release] Bumped lighttpd version to 5.0.0

* [Release] Bumped linkerd version to 6.0.0

* [Release] Bumped linux_proc_extras version to 4.0.0

* [Release] Bumped mapr version to 3.0.0

* [Release] Bumped mapreduce version to 6.0.0

* [Release] Bumped marathon version to 4.0.0

* [Release] Bumped marklogic version to 6.0.0

* [Release] Bumped mcache version to 6.0.0

* [Release] Bumped mesos_master version to 5.0.0

* [Release] Bumped mesos_slave version to 5.0.0

* [Release] Bumped mongo version to 8.0.0

* [Release] Bumped mysql version to 14.0.0

* [Release] Bumped nagios version to 3.0.0

* [Release] Bumped network version to 5.0.0

* [Release] Bumped nfsstat version to 3.0.0

* [Release] Bumped nginx version to 8.0.0

* [Release] Bumped nginx_ingress_controller version to 4.0.0

* [Release] Bumped nvidia_triton version to 2.1.0

* [Release] Bumped openldap version to 3.0.0

* [Release] Bumped openmetrics version to 6.0.0

* [Release] Bumped openstack version to 4.0.0

* [Release] Bumped openstack_controller version to 8.0.0

* [Release] Bumped pan_firewall version to 3.0.0

* [Release] Bumped pdh_check version to 4.0.0

* [Release] Bumped pgbouncer version to 8.0.0

* [Release] Bumped php_fpm version to 5.0.0

* [Release] Bumped postfix version to 3.0.0

* [Release] Bumped postgres version to 22.0.0

* [Release] Bumped powerdns_recursor version to 4.0.0

* [Release] Bumped presto version to 3.1.0

* [Release] Bumped process version to 5.0.0

* [Release] Bumped prometheus version to 5.0.0

* [Release] Bumped proxysql version to 7.0.0

* [Release] Bumped pulsar version to 3.1.0

* [Release] Bumped rabbitmq version to 7.0.0

* [Release] Bumped ray version to 2.1.0

* [Release] Bumped redisdb version to 7.0.0

* [Release] Bumped rethinkdb version to 5.0.0

* [Release] Bumped riak version to 5.0.0

* [Release] Bumped riakcs version to 4.0.0

* [Release] Bumped sap_hana version to 5.0.0

* [Release] Bumped scylla version to 4.0.0

* [Release] Bumped sidekiq version to 3.0.0

* [Release] Bumped silk version to 4.0.0

* [Release] Bumped singlestore version to 4.0.0

* [Release] Bumped snmp version to 9.0.0

* [Release] Bumped snowflake version to 7.0.0

* [Release] Bumped solr version to 2.1.0

* [Release] Bumped sonarqube version to 5.0.0

* [Release] Bumped spark version to 6.0.0

* [Release] Bumped sqlserver version to 19.0.0

* [Release] Bumped squid version to 4.0.0

* [Release] Bumped ssh_check version to 4.0.0

* [Release] Bumped statsd version to 3.0.0

* [Release] Bumped strimzi version to 3.1.0

* [Release] Bumped supervisord version to 4.0.0

* [Release] Bumped system_core version to 4.0.0

* [Release] Bumped system_swap version to 3.0.0

* [Release] Bumped tcp_check version to 6.0.0

* [Release] Bumped teamcity version to 6.0.0

* [Release] Bumped tekton version to 2.1.0

* [Release] Bumped teleport version to 2.1.0

* [Release] Bumped temporal version to 3.1.0

* [Release] Bumped tenable version to 3.0.0

* [Release] Bumped teradata version to 4.0.0

* [Release] Bumped tibco_ems version to 2.0.1

* [Release] Bumped tls version to 4.0.0

* [Release] Bumped tomcat version to 4.0.0

* [Release] Bumped torchserve version to 3.1.0

* [Release] Bumped traefik_mesh version to 2.1.0

* [Release] Bumped traffic_server version to 3.1.0

* [Release] Bumped twemproxy version to 3.0.0

* [Release] Bumped twistlock version to 5.0.0

* [Release] Bumped varnish version to 4.0.0

* [Release] Bumped vault version to 6.0.0

* [Release] Bumped vertica version to 6.0.0

* [Release] Bumped vllm version to 2.1.0

* [Release] Bumped voltdb version to 5.0.0

* [Release] Bumped weaviate version to 3.1.0

* [Release] Bumped weblogic version to 3.0.0

* [Release] Bumped win32_event_log version to 5.0.0

* [Release] Bumped windows_performance_counters version to 3.1.0

* [Release] Bumped windows_service version to 6.0.0

* [Release] Bumped wmi_check version to 3.0.0

* [Release] Bumped yarn version to 7.0.0

* [Release] Bumped zk version to 6.0.0

* [Release] Update metadata

* Update kube_apiserver_metrics/CHANGELOG.md

Co-authored-by: Sandra (neko) <165049174+neko-dd@users.noreply.github.com>

* Update postgres/CHANGELOG.md

Co-authored-by: Sandra (neko) <165049174+neko-dd@users.noreply.github.com>

* Update postgres/CHANGELOG.md

Co-authored-by: Sandra (neko) <165049174+neko-dd@users.noreply.github.com>

* Update postgres/CHANGELOG.md

Co-authored-by: Sandra (neko) <165049174+neko-dd@users.noreply.github.com>

* Update sqlserver/CHANGELOG.md

Co-authored-by: Sandra (neko) <165049174+neko-dd@users.noreply.github.com>

* Update dcgm/CHANGELOG.md

Co-authored-by: Sandra (neko) <165049174+neko-dd@users.noreply.github.com>

* Update mysql/CHANGELOG.md

Co-authored-by: Sandra (neko) <165049174+neko-dd@users.noreply.github.com>

* Update mysql/CHANGELOG.md

Co-authored-by: Sandra (neko) <165049174+neko-dd@users.noreply.github.com>

---------

Co-authored-by: Kyle Neale <kyle.neale@datadoghq.com>
Co-authored-by: HadhemiDD <43783545+HadhemiDD@users.noreply.github.com>
Co-authored-by: Sandra (neko) <165049174+neko-dd@users.noreply.github.com>

* Update metadata to retrigger wheel release (#18790)

* revert in toto file

---------

Co-authored-by: Ilia Kurenkov <ilia.kurenkov@datadoghq.com>
Co-authored-by: datadog-agent-integrations-bot[bot] <159767151+datadog-agent-integrations-bot[bot]@users.noreply.github.com>
Co-authored-by: Branden Clark <branden.clark@datadoghq.com>
Co-authored-by: Kyle Neale <kyle.neale@datadoghq.com>
Co-authored-by: Sandra (neko) <165049174+neko-dd@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kyle-Neale Kyle-Neale Kyle-Neale approved these changes

Assignees
No one assigned
Labels
agent/approved backport bot ecosystems/review-requested integration/network product/review-requested team/agent-integrations team/windows-agent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kyle-Neale @clarkb7