Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDSaaS: Metabase: Crawler Integration v1.0.0 #18720

Merged

Conversation

bparmar-crest
Copy link
Contributor

What does this PR do?

  • This is an initial release PR of Metabase integration including all the required assets.

Additional Notes

  • Crawler code for this integration has been committed in its respective repo
  • The assets are available in our sandbox and can be shared separately with the required teams.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

michaelcretzman
michaelcretzman previously approved these changes Oct 1, 2024
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
abhi-modugula and others added 5 commits January 30, 2025 11:35
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
@abhi-modugula abhi-modugula requested a review from rtrieu January 30, 2025 16:41
gunterd
gunterd previously approved these changes Jan 30, 2025
@gunterd gunterd dismissed their stale review January 30, 2025 20:07

Checking CI for logs pipeline

Copy link
Contributor

@gunterd gunterd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving logs pipeline

@abhi-modugula abhi-modugula added this pull request to the merge queue Jan 31, 2025
Merged via the queue into DataDog:master with commit dfff594 Jan 31, 2025
52 of 53 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 31, 2025
* Metabase integration assets

* CI build fixes

* CI build fixes

* Blank lines added

* Monitors description modified and manifest.json

* Corrected dashboard typos

* Updated assets as part of enhancement

* Removed dashboard images to honour the media limit

* Resolved monitor check failure

* Added services in log pipeline tests

* Resolved log pipeline tests check

* Normalized view log table fields

* Corrected log pipeline test

* Updated log pipeline test sample

* Corrected log pipeline test null values

* Resolved log pipeline test failure

* Minor changes

* Updated a dashboard image

* Updated README config part

* Resolved internal review comments

* README statement corrected

* CODEOWNERS added

* Integration name removed from monitors

* README.md modified

* README modified.

* Update manifest.json

* Update manifest.json

* Update metabase/assets/monitors/high_number_of_user_deactivations.json

Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>

* Update metabase/README.md

Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>

* Update metabase/README.md

Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>

* Update metabase/README.md

Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>

* Update metabase/README.md

Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>

* Update metabase/README.md

Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>

---------

Co-authored-by: Mauneel Sorathia <mauneel.sorathia@crestdata.ai>
Co-authored-by: abhi-modugula <abhi.modugula@datadoghq.com>
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com> dfff594
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.