Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated warning log message #18056

Closed
wants to merge 4 commits into from
Closed

Updated warning log message #18056

wants to merge 4 commits into from

Conversation

UTXOnly
Copy link
Contributor

@UTXOnly UTXOnly commented Jul 17, 2024

What does this PR do?

  • Updates a log message to include dbname variable

Motivation

Warning log currently includes variable name in curly braces instead of variable value

Example:

2024-07-10 17:43:14 UTC | CORE | WARN | (pkg/collector/python/datadog_agent.go:131 in LogMessage) | postgres:b6f6e4cc109a2ecc | (metadata.py:334) | Relation metrics are not configured for {dbname}, so tables cannot be collected

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.24%. Comparing base (1f0af38) to head (9dc12e3).
Report is 873 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
postgres 93.14% <0.00%> (+8.01%) ⬆️
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

dkirov-dd
dkirov-dd previously approved these changes Jul 19, 2024
Copy link

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@dd-devflow dd-devflow bot closed this Jan 19, 2025
@dd-devflow dd-devflow bot deleted the UTXOnly/log_update branch January 19, 2025 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants