Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dbm] fix flapping sqlserver_version #17750

Merged
merged 4 commits into from
Jun 6, 2024
Merged

Conversation

ynnadkrap
Copy link
Contributor

What does this PR do?

We received customer reports about missing sqlserver_version. The problem is that we store the version in a cache that has a 1 day TTL, and we never refresh the cache. The fix is to refresh the cache during each check run.

You can see the problem here where I changed the TTL to 5 minutes:

image

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@jmeunier28
Copy link
Contributor

We received customer reports about missing sqlserver_version. The problem is that we store the version in a cache that has a 1 day TTL, and we never refresh the cache.

:face-palm:

@ynnadkrap ynnadkrap merged commit b880923 into master Jun 6, 2024
36 checks passed
@ynnadkrap ynnadkrap deleted the danny.park/sqlserver-version branch June 6, 2024 13:36
jmeunier28 added a commit that referenced this pull request Aug 8, 2024
jmeunier28 added a commit that referenced this pull request Aug 8, 2024
datadog-agent-integrations-bot bot pushed a commit that referenced this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants