Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sidecar injection section to EKS Fargate readme #17209

Merged
merged 5 commits into from
Mar 21, 2024

Conversation

levan-m
Copy link
Contributor

@levan-m levan-m commented Mar 19, 2024

What does this PR do?

Adds a section describing upcoming feature in Datadog Agent 7.52 release.

Related Helm PR
DataDog/helm-charts#1348

CECO-888

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

@jhgilbert jhgilbert added the editorial review Waiting on a more in-depth review from a docs team editor label Mar 19, 2024
cswatt
cswatt previously approved these changes Mar 19, 2024
Co-authored-by: levan-m <116471169+levan-m@users.noreply.github.com>
@levan-m
Copy link
Contributor Author

levan-m commented Mar 21, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Mar 21, 2024

🚂 MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@steveny91 steveny91 merged commit 0a960cb into master Mar 21, 2024
37 checks passed
@steveny91 steveny91 deleted the levan-m/dca-sidecar-injection branch March 21, 2024 15:01
@dd-devflow
Copy link

dd-devflow bot commented Mar 21, 2024

🚂 MergeQueue

This pull request was merged directly.

@binitapoudel1
Copy link

Hello Team, the document has an error on the following line:

Admission Controller
This feature requires Cluster Agent v7.52.0+ and the [ECS Fargate integration].

I believe instead of ECS Fargate integration it should rather state EKS Fargate integration. please review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants