Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new scheduler_pod_scheduling_sli_duration_seconds metric #17110

Merged

Conversation

davidor
Copy link
Member

@davidor davidor commented Mar 8, 2024

What does this PR do?

Adds support for the new scheduler_pod_scheduling_sli_duration_seconds metric. It was introduced in Kubernetes 1.29 and replaces the now deprecated scheduler_pod_scheduling_duration_seconds.

Additional Notes

The tests added follow the same structure as the existing ones but use an input based on Kubernetes 1.29.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

@davidor davidor requested review from a team as code owners March 8, 2024 10:49
@davidor davidor changed the title Support new scheduler_pod_scheduling_sli_duration_seconds metric Support new scheduler_pod_scheduling_sli_duration_seconds metric Mar 8, 2024
@davidor davidor force-pushed the davidor/contint-3845-kube-scheduler-deprecated-metric branch from a62a442 to 897d0d7 Compare March 8, 2024 10:51
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.04%. Comparing base (9ecc2c9) to head (897d0d7).
Report is 45 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
confluent_platform ?
hive ?
hivemq ?
ignite ?
jboss_wildfly ?
kafka ?
kube_scheduler 97.92% <100.00%> (+0.28%) ⬆️
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

github-actions bot commented Mar 8, 2024

Test Results

 4 files   4 suites   9s ⏱️
13 tests 13 ✅ 0 💤 0 ❌
28 runs  26 ✅ 2 💤 0 ❌

Results for commit 897d0d7.

@davidor davidor merged commit a4385af into master Mar 11, 2024
37 checks passed
@davidor davidor deleted the davidor/contint-3845-kube-scheduler-deprecated-metric branch March 11, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants