Use forked version of auditwheel with correct rpath patching #16777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f1916a0 to
ed86222
Compare
ofek
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes version of auditwheel to use a patched fork that sets the RPATH the way we want.
pypa/auditwheel@main...DataDog:auditwheel:alopez/set-correct-rpath-on-copied-libs
Motivation
When trying to integrate our repaired wheels into the Agent build, Omnibus' health check failed. The reason is related to what is reported in pypa/auditwheel#451. The summary of the issue is that
lddcan't find the libraries linked from libraries that are copied into the wheel because theRPATHof the copied libraries does not point to the right location.Additional Notes
This required some changes to the repair script that calls functions within auditwheel because apparently that API is not really stable.
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.