Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump service-identity version to 23.1.0 #16558

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Bump service-identity version to 23.1.0 #16558

merged 1 commit into from
Jan 15, 2024

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Jan 8, 2024 •
edited
Loading

What does this PR do?

Bump service-identity version to 23.1.0 and fix the tests accordingly

Motivation

Similar issue we had in #15127 but for service-identify, see their changelog

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@FlorentClarret FlorentClarret force-pushed the florentclarret/tls/bump_dep branch from 4162862 to 358a2d2 Compare January 8, 2024 12:47
@FlorentClarret FlorentClarret mentioned this pull request Jan 8, 2024
Merged
3 tasks
@FlorentClarret FlorentClarret force-pushed the florentclarret/tls/bump_dep branch from 358a2d2 to 67a91ba Compare January 8, 2024 12:58
@FlorentClarret FlorentClarret added this to the 7.52.0 milestone Jan 8, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (02c2986) 90.54% compared to head (67a91ba) 90.64%.
Report is 11 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
confluent_platform ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
tls 92.07% <ø> (+0.82%) ⬆️
tomcat ?
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2024

Test Results

  4 files    4 suites   1m 12s ⏱️
 54 tests  53 ✅ 1 💤 0 ❌
110 runs  106 ✅ 4 💤 0 ❌

Results for commit 67a91ba.

@FlorentClarret FlorentClarret marked this pull request as ready for review January 8, 2024 14:23
@FlorentClarret FlorentClarret requested a review from a team as a code owner January 8, 2024 14:23
@FlorentClarret FlorentClarret merged commit a475e81 into master Jan 15, 2024
35 checks passed
@FlorentClarret FlorentClarret deleted the florentclarret/tls/bump_dep branch January 15, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveny91 steveny91 steveny91 approved these changes

Assignees
No one assigned
Labels
base_package dependencies integration/tls team/agent-integrations
Projects
None yet
Milestone
7.52.0
Development

Successfully merging this pull request may close these issues.
2 participants
@FlorentClarret @steveny91