Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing config_models files and update the base check version #16298

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Nov 29, 2023

What does this PR do?

  • Add missing config_models files
  • Update the min base check version

Motivation

We use the config models to ease validation across all the integrations in integrations-core. Somehow we missed this integration when we generate the models back then

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #16298 (26e3e07) into master (b5b2cfa) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
Flag Coverage Δ
confluent_platform ?
hudi ?
kubernetes_state 89.50% <ø> (+1.47%) ⬆️
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

Test Results

  4 files    4 suites   49s ⏱️
13 tests 13 ✔️ 0 💤 0
28 runs  26 ✔️ 2 💤 0

Results for commit 26e3e07.

@FlorentClarret FlorentClarret merged commit 2d9cc8d into master Nov 29, 2023
37 checks passed
@FlorentClarret FlorentClarret deleted the florentclarret/kube_state/config_models branch November 29, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants