Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump librdkafka and confluent-kafka to v2.3.0 #16088

Merged
merged 4 commits into from
Oct 27, 2023
Merged

Bump librdkafka and confluent-kafka to v2.3.0 #16088

merged 4 commits into from
Oct 27, 2023

Conversation

vivek-datadog
Copy link
Contributor

@vivek-datadog vivek-datadog commented Oct 26, 2023 •
edited
Loading

What does this PR do?

Motivation

Additional Notes

Agent PR: DataDog/datadog-agent#20424

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

@vivek-datadog vivek-datadog force-pushed the vivek-datadog/AGENT-10479 branch from a7a50b0 to c1d4a45 Compare October 26, 2023 09:36
@vivek-datadog vivek-datadog force-pushed the vivek-datadog/AGENT-10479 branch from c1d4a45 to 9aacd2c Compare October 26, 2023 09:42
@ghost ghost added the documentation label Oct 26, 2023
@vivek-datadog vivek-datadog changed the title Bump librdkafka to v2.3.0 Bump librdkafka and confluent-kafka to v2.3.0 Oct 26, 2023
@github-actions
Copy link

github-actions bot commented Oct 26, 2023 •
edited
Loading

Test Results

    8 files      8 suites   6m 30s ⏱️
  64 tests   64 ✔️ 0 💤 0 ❌
260 runs  256 ✔️ 4 💤 0 ❌

Results for commit 9e61d1c.

♻️ This comment has been updated with latest results.

@vivek-datadog vivek-datadog force-pushed the vivek-datadog/AGENT-10479 branch from f44a628 to a8396c0 Compare October 26, 2023 13:29
FlorentClarret
FlorentClarret reviewed Oct 26, 2023
View reviewed changes
Copy link
Member

@FlorentClarret FlorentClarret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You miss this one

integrations-core/kafka_consumer/hatch.toml

Line 7 in 1a52082

"python -m pip install --no-binary confluent-kafka confluent-kafka==2.2.0",

.ddev/ci/scripts/kafka_consumer/linux/32_install_kerberos.sh Outdated Show resolved Hide resolved
@vivek-datadog vivek-datadog force-pushed the vivek-datadog/AGENT-10479 branch from a8396c0 to 9cef0ad Compare October 26, 2023 15:54
@codecov
Copy link

codecov bot commented Oct 26, 2023 •
edited
Loading

Codecov Report

Merging #16088 (9e61d1c) into master (e7dddf7) will increase coverage by 0.13%.
The diff coverage is n/a.

Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
kafka_consumer 93.46% <ø> (+0.22%) ⬆️
presto ?
solr ?
tomcat ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@vivek-datadog vivek-datadog marked this pull request as ready for review October 27, 2023 06:54
@vivek-datadog vivek-datadog requested review from a team as code owners October 27, 2023 06:54
FlorentClarret
FlorentClarret requested changes Oct 27, 2023
View reviewed changes
Copy link
Member

@FlorentClarret FlorentClarret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment. Also could you update the description to include a link to the agent PR? Thanks!

datadog_checks_base/CHANGELOG.md Outdated Show resolved Hide resolved
@vivek-datadog vivek-datadog mentioned this pull request Oct 27, 2023
Merged
10 tasks
@vivek-datadog
Copy link
Contributor Author

Datadog agent PR: DataDog/datadog-agent#20424

@vivek-datadog vivek-datadog force-pushed the vivek-datadog/AGENT-10479 branch from ced9595 to e1adeea Compare October 27, 2023 07:13
@vivek-datadog vivek-datadog force-pushed the vivek-datadog/AGENT-10479 branch from e1adeea to 849147e Compare October 27, 2023 07:14
@vivek-datadog
Copy link
Contributor Author

Left a comment. Also could you update the description to include a link to the agent PR? Thanks!

Updated.

@vivek-datadog vivek-datadog merged commit 106cc88 into master Oct 27, 2023
27 checks passed
@vivek-datadog vivek-datadog deleted the vivek-datadog/AGENT-10479 branch October 27, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorentClarret FlorentClarret FlorentClarret approved these changes

Assignees
No one assigned
Labels
base_package changelog/no-changelog dependencies documentation integration/kafka_consumer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vivek-datadog @FlorentClarret