Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The right field name is platforms, not platform #16063

Merged
merged 3 commits into from
Oct 20, 2023
+2 −1
Merged

The right field name is platforms, not platform #16063

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28fbf4e
The right field name is `platforms`, not `platform`
alopezz Oct 20, 2023
b677bcb
Add changelog
alopezz Oct 20, 2023
12d292f
Merge branch 'master' into alopez/ddev/platforms
alopezz Oct 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ddev/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
***Fixed***:

* Fix `ddev env test` so that tests run for all environments properly when no environment is specified ([#16054](https://github.com/DataDog/integrations-core/pull/16054))
* Fix e2e test env detection to use `platforms`, not `platform` ([#16063](https://github.com/DataDog/integrations-core/pull/16063))

## 5.2.1 / 2023-10-12

Expand Down
2 changes: 1 addition & 1 deletion ddev/src/ddev/cli/env/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ def test_command(
name
for name, data in environments.items()
if data.get('e2e-env')
and (not data.get('platform') or app.platform.name in data['platform'])
and (not data.get('platforms') or app.platform.name in data['platforms'])
and (python_filter is None or data.get('python') == python_filter)
]
elif environment == 'active':
Expand Down