Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows service trigger_start filter to config #16038

Merged
merged 12 commits into from
Oct 24, 2023

Conversation

mrafi97
Copy link
Contributor

@mrafi97 mrafi97 commented Oct 17, 2023

What does this PR do?

Adds a new trigger_start pattern to the windows_service services config entry that enables users to filter services by whether or not they have triggers.

This new pattern combines with the existing patterns:

# Matches all services that do not have a trigger
services:
  - trigger_start: false

# Matches all services with an automatic startup type and excludes services with triggers
services:
  - startup_type: automatic
    trigger_start: false

# Only matches EventLog service when its startup type is automatic and has triggers
services:
  - name: EventLog
    startup_type: automatic
    trigger_start: true

Motivation

Jira: https://datadoghq.atlassian.net/browse/WINA-105

builds upon #12940 to allow service filtering based on name, startup_type and trigger_start

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #16038 (6bac452) into master (72eb55a) will increase coverage by 0.10%.
Report is 9 commits behind head on master.
The diff coverage is 80.00%.

Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
tomcat ?
weblogic ?
windows_service 94.75% <80.00%> (-3.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link

github-actions bot commented Oct 17, 2023

Test Results

  4 files    4 suites   49s ⏱️
20 tests 18 ✔️ 2 💤 0
42 runs  36 ✔️ 6 💤 0

Results for commit 6bac452.

♻️ This comment has been updated with latest results.

hestonhoffman
hestonhoffman previously approved these changes Oct 18, 2023
iglendd
iglendd previously approved these changes Oct 18, 2023
@mrafi97 mrafi97 dismissed stale reviews from iglendd and hestonhoffman via 0a6e8bd October 20, 2023 12:32
@mrafi97 mrafi97 force-pushed the mohammad.rafi/windows-service-trigger branch from a4aca2d to 0a6e8bd Compare October 20, 2023 12:32
@FlorentClarret FlorentClarret requested review from iglendd and removed request for iglendd October 24, 2023 13:50
@mrafi97 mrafi97 merged commit d93e894 into master Oct 24, 2023
@mrafi97 mrafi97 deleted the mohammad.rafi/windows-service-trigger branch October 24, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants