Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing timeout when looking up offsets #15630

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Add missing timeout when looking up offsets #15630

merged 2 commits into from
Aug 21, 2023

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Aug 21, 2023 •
edited
Loading

What does this PR do?

Add missing timeout when looking up offsets

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

@FlorentClarret FlorentClarret requested a review from a team as a code owner August 21, 2023 07:45
@FlorentClarret FlorentClarret force-pushed the florentclarret/kafka_consumer/missing_timeout branch from 7d8aeb6 to f87b70d Compare August 21, 2023 07:46
@FlorentClarret FlorentClarret requested a review from a team as a code owner August 21, 2023 07:46
@ghost ghost added the documentation label Aug 21, 2023
@github-actions
Copy link

github-actions bot commented Aug 21, 2023 •
edited
Loading

Test Results

    8 files      8 suites   5m 39s ⏱️
  47 tests   47 ✔️ 0 💤 0 ❌
192 runs  188 ✔️ 4 💤 0 ❌

Results for commit 60c35e5.

♻️ This comment has been updated with latest results.

@FlorentClarret FlorentClarret force-pushed the florentclarret/kafka_consumer/missing_timeout branch from f87b70d to 60c35e5 Compare August 21, 2023 08:03
@codecov
Copy link

codecov bot commented Aug 21, 2023 •
edited
Loading

Codecov Report

Merging #15630 (bfc9acb) into master (6f63a3d) will not change coverage.
Report is 2 commits behind head on master.
The diff coverage is 50.00%.

Flag Coverage Δ
kafka_consumer 93.38% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

iliakur
iliakur previously approved these changes Aug 21, 2023
View reviewed changes
@FlorentClarret FlorentClarret merged commit 06bcc54 into master Aug 21, 2023
@FlorentClarret FlorentClarret deleted the florentclarret/kafka_consumer/missing_timeout branch August 21, 2023 10:01
@FlorentClarret FlorentClarret added this to the 7.48.0 milestone Aug 21, 2023
vivek-datadog pushed a commit that referenced this pull request Aug 21, 2023
@FlorentClarret @vivek-datadog
Add missing timeout when looking up offsets (#15630)
7dc2c67 
* Add missing timeout when looking up offsets

* Update kafka_consumer/CHANGELOG.md
@vivek-datadog vivek-datadog added the category/improvement For use during Agent Release period label Aug 23, 2023
@FlorentClarret FlorentClarret mentioned this pull request Oct 26, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivek-datadog vivek-datadog vivek-datadog approved these changes

@iliakur iliakur iliakur left review comments

Assignees
No one assigned
Labels
category/improvement For use during Agent Release period documentation integration/kafka_consumer
Projects
None yet
Milestone
7.48.0
Development

Successfully merging this pull request may close these issues.
3 participants
@FlorentClarret @iliakur @vivek-datadog