Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump cryptography to 41.0.3 #15517

Merged
merged 3 commits into from
Aug 14, 2023
Merged

Bump cryptography to 41.0.3 #15517

merged 3 commits into from
Aug 14, 2023

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Aug 9, 2023 •
edited
Loading

What does this PR do?

Bump cryptography to 41.0.3

Motivation

Additional Notes

Needs #15504 and DataDog/datadog-agent#18757 to be merged first

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@codecov
Copy link

codecov bot commented Aug 9, 2023 •
edited
Loading

Codecov Report

Merging #15517 (3137ecc) into master (eb67d39) will increase coverage by 1.34%.
The diff coverage is n/a.

Flag Coverage Δ
cisco_aci 95.27% <ø> (ø)
datadog_checks_base 89.62% <ø> (+9.12%) ⬆️
http_check 96.09% <ø> (+2.15%) ⬆️
mysql 87.28% <ø> (ø)
tls 92.18% <ø> (+0.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link

github-actions bot commented Aug 9, 2023 •
edited
Loading

Test Results

     32 files       32 suites   42m 20s ⏱️
1 411 tests 1 393 ✔️   18 💤 0 ❌
5 886 runs  5 122 ✔️ 764 💤 0 ❌

Results for commit 3137ecc.

♻️ This comment has been updated with latest results.

@FlorentClarret FlorentClarret force-pushed the florentclarret/bump_cryptography branch from de85829 to 75f4869 Compare August 11, 2023 05:29
@ghost ghost added the documentation label Aug 11, 2023
@FlorentClarret FlorentClarret marked this pull request as ready for review August 11, 2023 05:36
@FlorentClarret FlorentClarret requested review from a team as code owners August 11, 2023 05:36
@FlorentClarret FlorentClarret mentioned this pull request Aug 11, 2023
Merged
10 tasks
brett0000FF
brett0000FF approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@brett0000FF brett0000FF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small suggestion to match the formatting of past entries.

cisco_aci/CHANGELOG.md
@@ -2,6 +2,10 @@

## Unreleased

***Fixed***:

* Bump cryptography to 41.0.3 ([#15517](https://github.com/DataDog/integrations-core/pull/15517))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Bump cryptography to 41.0.3 ([#15517](https://github.com/DataDog/integrations-core/pull/15517))
* Bump cryptography to 41.0.3. See [#15517](https://github.com/DataDog/integrations-core/pull/15517).

Small suggestion to match formatting of past entries.

Copy link
Member Author

@FlorentClarret FlorentClarret Aug 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are changing the format for the changelog. We will update the past entries to keep things consistent

http_check/CHANGELOG.md Show resolved Hide resolved
mysql/CHANGELOG.md Show resolved Hide resolved
tls/CHANGELOG.md Show resolved Hide resolved
@FlorentClarret FlorentClarret merged commit 858ad36 into master Aug 14, 2023
@FlorentClarret FlorentClarret deleted the florentclarret/bump_cryptography branch August 14, 2023 09:39
@vivek-datadog vivek-datadog mentioned this pull request Aug 14, 2023
Merged
3 tasks
@FlorentClarret FlorentClarret added this to the 7.48 milestone Aug 14, 2023
@vivek-datadog vivek-datadog added the qa/skip-qa Automatically skip this PR for the next QA label Aug 18, 2023
@L3n41c L3n41c mentioned this pull request Sep 8, 2023
Closed
@FlorentClarret FlorentClarret mentioned this pull request Sep 12, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivek-datadog vivek-datadog vivek-datadog approved these changes

@brett0000FF brett0000FF brett0000FF approved these changes

Assignees
No one assigned
Labels
base_package dependencies documentation integration/cisco_aci integration/http_check integration/mysql integration/tls qa/skip-qa Automatically skip this PR for the next QA
Projects
None yet
Milestone
7.48.0
Development

Successfully merging this pull request may close these issues.

Multiple Integrations use pyca/cryptography v39.0.1 which mishandles SSH certs.
3 participants
@FlorentClarret @brett0000FF @vivek-datadog