Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add peplink profile #15464

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Add peplink profile #15464

merged 1 commit into from
Aug 3, 2023

Conversation

FlorianVeaux
Copy link
Member

No description provided.

@FlorianVeaux FlorianVeaux requested review from a team as code owners August 3, 2023 08:15
@ghost ghost added the integration/snmp label Aug 3, 2023
NouhaManai96
NouhaManai96 reviewed Aug 3, 2023
View reviewed changes
snmp/datadog_checks/snmp/data/default_profiles/peplink.yaml
# symbol:
# name: peplink.balLanStatus
# OID: 1.3.6.1.4.1.23695.1.1.1.6.1
# format: TODO_handle_conversion_to_one
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be the equivalent of constant_value_one: true

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the conversion: to_one on kentik's side is the equivalent of constant_value_one: true on our side
example with this metric

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But isn't that only for table metrics at the moment? I don't think we have a way to support this with scalar metrics

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now, it's not possible to use conversion_to_one for a scalar metrics.

@codecov
Copy link

codecov bot commented Aug 3, 2023 •
edited
Loading

Codecov Report

Merging #15464 (60a7f48) into master (eca9aaf) will decrease coverage by 0.04%.
Report is 3 commits behind head on master.
The diff coverage is 16.27%.

Flag Coverage Δ
snmp 52.71% <16.27%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link

github-actions bot commented Aug 3, 2023

Test Results

       6 files      6 suites   28m 10s ⏱️
   377 tests 377 ✔️        0 💤 0 ❌
1 725 runs  557 ✔️ 1 168 💤 0 ❌

Results for commit 60a7f48.

@FlorianVeaux FlorianVeaux merged commit d5c676e into master Aug 3, 2023
@FlorianVeaux FlorianVeaux deleted the flo/peplink branch August 3, 2023 14:42
NouhaManai96 added a commit that referenced this pull request Aug 23, 2023
@NouhaManai96
fix mapping #15464
63b2137
NouhaManai96 added a commit that referenced this pull request Aug 31, 2023
@NouhaManai96 @AlexandreYang
Fix SNMP profiles metric tags mappings using MIBs (#15668)
a50ecaa 
* fix mapping for apc-netbotz #15136

* for mapping for aruba-wireless-controller #15128

* fix mapping #15482

* fix mapping #15158

* fix mapping #15414

* fix mapping #15312

* fix mapping #15343

* fix mapping #15374

* fix mapping #15354

* fix mapping #15370

* fix mapping #15464

* fix mapping #15326

* fix mapping #15368

* fix mapping #15368

* fix mapping #15396

* fix mapping #15386

* fix mapping #15469

* fix mappings #15265

* fix mapping #15349

* fix mapping #15356

* fix mapping #15371

* fix mapping #15322

* fix mapping #15397

* fix mappings #15466

* fix mapping #15153

* fix mapping cisco

* fix mapping

* fix mapping hp

* fix mapping poweredge

* fix mapping f5

* update servertech: metricnames + metadata +tests

* update apc netbotz tests

* update aruba wlc tests

* update citrix netscaler sdx test

* update dell os10 tests

* update test hpe nimble

* update tests huawei

* update infinera coriant groove tests

* update tests infoblox

* update tests kyocera

* update tests raritan

* update tests sinetica

* update tests sophos

* update test zyxel

* update tests avaya

* update tests cisco ucs

* update tests huawei routers

* update tests ibm datapower

* update tests tripplite ups

* update test avaya cajun

* update test barracuda cloudgen

* update test _cisco_generic

* update test cisco nexus

* update test assert_extend_cisco_generic

* update test dell

* update test hp compaq health

* update test f5-big-ip

* update metrics names

* address reviews

* add changelog

* lint

* update changelog

* fix mib name

* address reviews

* revert to readynasos mib mapping

* address review

* remove tag

* add spacing

* Fix changelog

* update changelog

* fix changelog

* remove unnecessary ip_address formatting

---------

Co-authored-by: Alexandre Yang <alexandre.yang@datadoghq.com>
github-actions bot pushed a commit that referenced this pull request Aug 31, 2023
@NouhaManai96
Fix SNMP profiles metric tags mappings using MIBs (#15668)
f130e03 
* fix mapping for apc-netbotz #15136

* for mapping for aruba-wireless-controller #15128

* fix mapping #15482

* fix mapping #15158

* fix mapping #15414

* fix mapping #15312

* fix mapping #15343

* fix mapping #15374

* fix mapping #15354

* fix mapping #15370

* fix mapping #15464

* fix mapping #15326

* fix mapping #15368

* fix mapping #15368

* fix mapping #15396

* fix mapping #15386

* fix mapping #15469

* fix mappings #15265

* fix mapping #15349

* fix mapping #15356

* fix mapping #15371

* fix mapping #15322

* fix mapping #15397

* fix mappings #15466

* fix mapping #15153

* fix mapping cisco

* fix mapping

* fix mapping hp

* fix mapping poweredge

* fix mapping f5

* update servertech: metricnames + metadata +tests

* update apc netbotz tests

* update aruba wlc tests

* update citrix netscaler sdx test

* update dell os10 tests

* update test hpe nimble

* update tests huawei

* update infinera coriant groove tests

* update tests infoblox

* update tests kyocera

* update tests raritan

* update tests sinetica

* update tests sophos

* update test zyxel

* update tests avaya

* update tests cisco ucs

* update tests huawei routers

* update tests ibm datapower

* update tests tripplite ups

* update test avaya cajun

* update test barracuda cloudgen

* update test _cisco_generic

* update test cisco nexus

* update test assert_extend_cisco_generic

* update test dell

* update test hp compaq health

* update test f5-big-ip

* update metrics names

* address reviews

* add changelog

* lint

* update changelog

* fix mib name

* address reviews

* revert to readynasos mib mapping

* address review

* remove tag

* add spacing

* Fix changelog

* update changelog

* fix changelog

* remove unnecessary ip_address formatting

---------

Co-authored-by: Alexandre Yang <alexandre.yang@datadoghq.com> a50ecaa
iliakur pushed a commit that referenced this pull request Sep 5, 2023
@NouhaManai96 @AlexandreYang @iliakur
Fix SNMP profiles metric tags mappings using MIBs (#15668)
0858837 
* fix mapping for apc-netbotz #15136

* for mapping for aruba-wireless-controller #15128

* fix mapping #15482

* fix mapping #15158

* fix mapping #15414

* fix mapping #15312

* fix mapping #15343

* fix mapping #15374

* fix mapping #15354

* fix mapping #15370

* fix mapping #15464

* fix mapping #15326

* fix mapping #15368

* fix mapping #15368

* fix mapping #15396

* fix mapping #15386

* fix mapping #15469

* fix mappings #15265

* fix mapping #15349

* fix mapping #15356

* fix mapping #15371

* fix mapping #15322

* fix mapping #15397

* fix mappings #15466

* fix mapping #15153

* fix mapping cisco

* fix mapping

* fix mapping hp

* fix mapping poweredge

* fix mapping f5

* update servertech: metricnames + metadata +tests

* update apc netbotz tests

* update aruba wlc tests

* update citrix netscaler sdx test

* update dell os10 tests

* update test hpe nimble

* update tests huawei

* update infinera coriant groove tests

* update tests infoblox

* update tests kyocera

* update tests raritan

* update tests sinetica

* update tests sophos

* update test zyxel

* update tests avaya

* update tests cisco ucs

* update tests huawei routers

* update tests ibm datapower

* update tests tripplite ups

* update test avaya cajun

* update test barracuda cloudgen

* update test _cisco_generic

* update test cisco nexus

* update test assert_extend_cisco_generic

* update test dell

* update test hp compaq health

* update test f5-big-ip

* update metrics names

* address reviews

* add changelog

* lint

* update changelog

* fix mib name

* address reviews

* revert to readynasos mib mapping

* address review

* remove tag

* add spacing

* Fix changelog

* update changelog

* fix changelog

* remove unnecessary ip_address formatting

---------

Co-authored-by: Alexandre Yang <alexandre.yang@datadoghq.com>
lizaerem added a commit that referenced this pull request Sep 20, 2023
@AlexandreYang @NouhaManai96
@lizaerem @jhgilbert
Add assert_all_profile_metrics_and_tags_covered & fix mappings in pro…
3632e04 
…files (#15720)

* fix mapping for apc-netbotz #15136

* for mapping for aruba-wireless-controller #15128

* fix mapping #15482

* fix mapping #15158

* fix mapping #15414

* fix mapping #15312

* fix mapping #15343

* fix mapping #15374

* fix mapping #15354

* fix mapping #15370

* fix mapping #15464

* fix mapping #15326

* fix mapping #15368

* fix mapping #15368

* fix mapping #15396

* fix mapping #15386

* fix mapping #15469

* fix mappings #15265

* fix mapping #15349

* fix mapping #15356

* fix mapping #15371

* fix mapping #15322

* fix mapping #15397

* fix mappings #15466

* fix mapping #15153

* fix mapping cisco

* fix mapping

* fix mapping hp

* fix mapping poweredge

* fix mapping f5

* update servertech: metricnames + metadata +tests

* update apc netbotz tests

* update aruba wlc tests

* update citrix netscaler sdx test

* update dell os10 tests

* update test hpe nimble

* update tests huawei

* update infinera coriant groove tests

* update tests infoblox

* update tests kyocera

* update tests raritan

* update tests sinetica

* update tests sophos

* update test zyxel

* update tests avaya

* update tests cisco ucs

* update tests huawei routers

* update tests ibm datapower

* update tests tripplite ups

* update test avaya cajun

* update test barracuda cloudgen

* update test _cisco_generic

* update test cisco nexus

* update test assert_extend_cisco_generic

* update test dell

* update test hp compaq health

* update test f5-big-ip

* update metrics names

* address reviews

* add changelog

* lint

* update changelog

* fix mib name

* address reviews

* revert to readynasos mib mapping

* address review

* remove tag

* add spacing

* Fix changelog

* update changelog

* fix changelog

* remove unnecessary ip_address formatting

* Add assert_all_profile_metrics_and_tags_covered

* fix empty space

* Add assert_all_profile_metrics_and_tags_covered

* Add to test_profile__checkpoint_firewall_cpu_memory.py

* Add assertions

* better msg

* format

* not use f string

* not use f string

* Add ASSERT_ALL_PROFILE_EXCLUDED_TAGS

* fix cisco profiles tags & snmprec & test

* fix dell-rac snmprec (tag) & test

* fix _generic-entity-sensor snmprec (tags + mapping) & test

* fix alcatel-lucent-ent snmprec (tags + mapping) & test

* fix alcatel-lucent-ind (tags + mapping) & test

* rename anue-packet-broker snmprec to anue

* better test output

* fix aruba-clearpass tags & snmprec & test

* fix aruba-wc snmprec & test

* fix bluecat-server snmprec & test

* fix checkpoint snmprec & test

* fix eaton-epdu profile & test

* fix hp-h3c-switch snmprec & test

* fix huawei-routers snmprec & test

* fix infinera-coriant-groove snmprec & test

* fix juniper-variation test

* fix juniper-pulse-secure tags & snmprec & test

* fix nasuni-filer tags & snmprec & test

* fix meraki-cloud-controller device tag name

* fix netgear-readynas tag & snmprec & test

* fix riverbed-interceptor (comment scalar metric)

* fix servertech-pdu4 snmprec & test

* fix sinetica-eagle-i snmprec & test

* fix western-digital snmprec & test

* revert netgear-readynas & resolve conflict

* Update western-digital-mycloud-ex2-ultra.snmprec

fix type in snmprec for western-digital

* Update infinera-coriant-groove.snmprec

fix type in snmprec for infinera-coriant

* Update netgear-readynas.snmprec

fix type in snmprec for netgear-readynas

* update test_profiles.py

* update core tests

* let arista-switch test pass & fix it separately

* minor changes to profiles

* update _cisco-generic with the tooling

* update alcatel-lucent-ent with the tooling

* update alcatel-lucent-ind with the tooling

* update alcatel-lucent-omni-access-wlc with the tooling

* update aruba-wireless-controller with the tooling

* fix tests for cisco profiles

* update test for arista after fixing extends in profiles

* add changelog

* (turns out we cannot fix previous changelogs)

* fix mapping #15322

* rebase on master

* update test barracuda cloudgen

* address reviews

* address reviews

* revert to readynasos mib mapping

* remove tag

* Add assert_all_profile_metrics_and_tags_covered

* fix empty space

* Add assert_all_profile_metrics_and_tags_covered

* Add to test_profile__checkpoint_firewall_cpu_memory.py

* Add assertions

* better msg

* format

* not use f string

* not use f string

* Add ASSERT_ALL_PROFILE_EXCLUDED_TAGS

* fix cisco profiles tags & snmprec & test

* fix dell-rac snmprec (tag) & test

* fix _generic-entity-sensor snmprec (tags + mapping) & test

* fix alcatel-lucent-ent snmprec (tags + mapping) & test

* fix alcatel-lucent-ind (tags + mapping) & test

* rename anue-packet-broker snmprec to anue

* better test output

* fix aruba-clearpass tags & snmprec & test

* fix aruba-wc snmprec & test

* fix bluecat-server snmprec & test

* fix checkpoint snmprec & test

* fix eaton-epdu profile & test

* fix hp-h3c-switch snmprec & test

* fix huawei-routers snmprec & test

* fix infinera-coriant-groove snmprec & test

* fix juniper-variation test

* fix juniper-pulse-secure tags & snmprec & test

* fix nasuni-filer tags & snmprec & test

* fix meraki-cloud-controller device tag name

* rebase

* fix servertech-pdu4 snmprec & test

* fix sinetica-eagle-i snmprec & test

* fix western-digital snmprec & test

* rebase

* Update western-digital-mycloud-ex2-ultra.snmprec

fix type in snmprec for western-digital

* Update infinera-coriant-groove.snmprec

fix type in snmprec for infinera-coriant

* rebase

* update test_profiles.py

* update core tests

* let arista-switch test pass & fix it separately

* minor changes to profiles

* update _cisco-generic with the tooling

* update alcatel-lucent-ent with the tooling

* update alcatel-lucent-ind with the tooling

* update alcatel-lucent-omni-access-wlc with the tooling

* fix tests for cisco profiles

* update test for arista after fixing extends in profiles

* add changelog

* (turns out we cannot fix previous changelogs)

* fix mapping #15322

* address reviews

* address reviews

* fix nasuni-filer tags & snmprec & test

* rebase

* rebase

* let arista-switch test pass & fix it separately

* minor changes to profiles

* update test for arista after fixing extends in profiles

* fix cisco_nexus mapping & test for netgear

* delete jupiter-variation.yaml

* Update changelog

Co-authored-by: jhgilbert <jen.gilbert@datadoghq.com>

* fix netgear-readynas

* unexpected failure due to diagnoses metadata

* diagnoses metadata

* diagnoses metadata

---------

Co-authored-by: NouhaManai <nouha.manai@yahoo.fr>
Co-authored-by: lizaerem <elizaveta.eremina@datadoghq.com>
Co-authored-by: Elizaveta Eremina <70374721+lizaerem@users.noreply.github.com>
Co-authored-by: jhgilbert <jen.gilbert@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexandreYang AlexandreYang AlexandreYang left review comments

@NouhaManai96 NouhaManai96 NouhaManai96 approved these changes

Assignees
No one assigned
Labels
integration/snmp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FlorianVeaux @AlexandreYang @NouhaManai96