[SNMP] Add profile for IBM Lenovo servers #15377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
ThibaudC/SNMP-profile-IBM-datapower-gateway
to
master
July 26, 2023 08:28
# Conflicts: # snmp/metadata.csv
| name: diskTable | ||
| OID: 1.3.6.1.4.1.2.3.51.3.1.12.2 | ||
| symbols: | ||
| - name: ibm.disk |
There was a problem hiding this comment.
ibm.disk seems very generic even with ibm prefix. It might conflicts with other ibm.
I think we should prefix everything ibm.imm. to:
- avoid conflicts
- can make it easier for user to search for metrics related to IMM (Integrated Management Module) related things.
There was a problem hiding this comment.
Makes sense, changed prefix to ibm.imm
AlexandreYang
requested changes
Jul 26, 2023
| @@ -0,0 +1,156 @@ | |||
| extends: | |||
| - _base.yaml | |||
There was a problem hiding this comment.
no need for this since ibm.yaml already extends _base.yaml
Suggested change
| - _base.yaml |
There was a problem hiding this comment.
Changed prefix to ibm.imm as suggested by @AlexandreYang
NouhaManai96
approved these changes
Jul 26, 2023
AlexandreYang
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add profile for IBM Lenovo servers
Depends on #15371
Motivation
Additional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attachedqa/skip-qalabel.