Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types for generated config models #15334

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Fix types for generated config models #15334

merged 1 commit into from
Jul 27, 2023

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Jul 21, 2023

What does this PR do?

This removes the warning about type mismatches by changing the type definitions to the end result

Additional Notes

  • Refactored the logic to utilize a single validation function in order to reduce the cognitive overhead of determining what runs when and with access to what inputs
  • The immutable mapping type now relies only on the standard library, removing the need for a dependency (the option to allow arbitrary types is required until this is fixed FR: native handling of MappingProxyType pydantic/pydantic#6868)
  • Type definitions now use the built-in types for containers
  • Documentation will be updated in a subsequent PR

@ofek ofek requested review from a team as code owners July 21, 2023 04:10
@ofek ofek requested a review from a team July 21, 2023 04:10
@ofek ofek requested a review from a team as a code owner July 21, 2023 04:10
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #15334 (fca2e2b) into master (ee8be9f) will increase coverage by 0.01%.
Report is 6 commits behind head on master.
The diff coverage is 90.90%.

Flag Coverage Δ
active_directory 100.00% <ø> (+17.64%) ⬆️
activemq_xml 82.31% <ø> (ø)
amazon_msk 89.07% <ø> (ø)
ambari 85.75% <ø> (ø)
apache 95.08% <ø> (ø)
arangodb 98.23% <ø> (ø)
argocd 88.04% <ø> (ø)
aspdotnet 100.00% <ø> (ø)
avi_vantage 91.35% <ø> (ø)
azure_iot_edge 82.08% <ø> (ø)
boundary 100.00% <ø> (ø)
btrfs 82.91% <ø> (ø)
cacti 87.90% <ø> (ø)
calico 84.41% <ø> (ø)
cert_manager 77.41% <ø> (ø)
cisco_aci 95.27% <ø> (ø)
citrix_hypervisor 87.50% <ø> (ø)
cloud_foundry_api 96.35% <ø> (+0.12%) ⬆️
cloudera 99.49% <100.00%> (+<0.01%) ⬆️
crio 89.79% <ø> (ø)
datadog_checks_dev 82.60% <90.56%> (+0.04%) ⬆️
datadog_checks_downloader 81.65% <ø> (ø)
datadog_cluster_agent 90.19% <ø> (ø)
dcgm 97.33% <ø> (ø)
ddev 98.78% <ø> (-0.48%) ⬇️
directory 96.09% <ø> (+0.65%) ⬆️
disk 89.23% <ø> (-2.14%) ⬇️
dns_check 93.90% <ø> (ø)
druid 98.47% <ø> (ø)
ecs_fargate 83.06% <ø> (ø)
eks_fargate 94.05% <ø> (ø)
external_dns 89.28% <ø> (ø)
foundationdb 78.50% <ø> (ø)
go_expvar 92.73% <ø> (ø)
gunicorn 92.10% <ø> (ø)
hazelcast 92.39% <ø> (ø)
hdfs_datanode 89.74% <ø> (ø)
http_check 96.09% <ø> (+2.15%) ⬆️
ibm_i 81.91% <ø> (ø)
impala 97.97% <ø> (ø)
istio 77.43% <ø> (+0.55%) ⬆️
kube_apiserver_metrics 97.85% <ø> (ø)
kube_controller_manager 96.00% <ø> (ø)
kube_dns 95.97% <ø> (ø)
kube_metrics_server 94.87% <ø> (ø)
kube_proxy 96.80% <ø> (ø)
kube_scheduler 96.53% <ø> (ø)
kubelet 90.99% <ø> (ø)
kubernetes_state 89.18% <ø> (ø)
kyototycoon 85.96% <ø> (ø)
linux_proc_extras 96.22% <ø> (ø)
mapr 82.70% <ø> (ø)
marathon 83.43% <ø> (ø)
mcache 93.50% <ø> (ø)
nagios 89.01% <ø> (ø)
network 94.01% <ø> (+1.10%) ⬆️
nfsstat 95.20% <ø> (ø)
nginx_ingress_controller 98.36% <ø> (ø)
openldap 96.79% <ø> (ø)
openmetrics 98.08% <ø> (ø)
openstack 51.45% <ø> (ø)
openstack_controller 91.12% <ø> (ø)
php_fpm 90.25% <ø> (+0.84%) ⬆️
postfix 88.04% <ø> (ø)
process 85.42% <ø> (+0.28%) ⬆️
prometheus 94.17% <ø> (ø)
pulsar 100.00% <ø> (ø)
riak 99.22% <ø> (ø)
silk 93.82% <ø> (ø)
singlestore 90.81% <ø> (ø)
snowflake 96.61% <ø> (ø)
squid 100.00% <ø> (ø)
statsd 87.36% <ø> (+1.05%) ⬆️
strimzi 89.70% <ø> (ø)
supervisord 92.69% <ø> (ø)
system_core 90.90% <ø> (ø)
system_swap 98.30% <ø> (ø)
tcp_check 91.58% <ø> (-1.35%) ⬇️
temporal 100.00% <ø> (ø)
teradata 94.06% <ø> (ø)
tls 92.18% <ø> (+0.82%) ⬆️
tokumx 58.40% <ø> (ø)
torchserve 97.33% <ø> (ø)
traffic_server 96.13% <ø> (ø)
twemproxy 79.45% <ø> (ø)
twistlock 79.62% <ø> (ø)
weaviate 76.27% <ø> (ø)
yarn 89.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link

github-actions bot commented Jul 21, 2023

Test Results

     949 files       949 suites   6h 19m 30s ⏱️
  5 105 tests   5 019 ✔️      78 💤 4  4 🔥
20 817 runs  17 839 ✔️ 2 970 💤 4  4 🔥

For more details on these failures and errors, see this check.

Results for commit fca2e2b.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@ofek ofek force-pushed the ofek/pydantic branch 2 times, most recently from 314cb62 to edb3cbb Compare July 27, 2023 03:49
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@ofek ofek merged commit c9f17ef into master Jul 27, 2023
@ofek ofek deleted the ofek/pydantic branch July 27, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: native handling of MappingProxyType
2 participants