Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stored proc yaml example for driver info #1467

Merged
merged 1 commit into from
Apr 27, 2018

Conversation

nmuesch
Copy link
Collaborator

@nmuesch nmuesch commented Apr 26, 2018

What does this PR do?

Clarifies that the stored proc functionality won't work with the pyodbc driver. (adodbapi is the default)

Motivation

Pyodbc doesn't implement the callproc method so using stored procedures when that implementation is chosen in the conf.yaml won't work.

Testing Guidelines

An overview on testing
is available in our contribution guidelines.

Versioning

  • Bumped the check version in manifest.json
  • Bumped the check version in datadog_checks/{integration}/__init__.py
  • Updated CHANGELOG.md. Please use Unreleased as the date in the title
    for the new section.
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

Additional Notes

Anything else we should know when reviewing?

@nmuesch nmuesch merged commit ba2fc8e into master Apr 27, 2018
@nmuesch nmuesch deleted the nick/update_sqlserver_yaml_stored_proc branch April 27, 2018 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants