Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors related to filtering based on user-specified consumer groups filters #14406

Merged
merged 15 commits into from
Apr 19, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add extra test case
  • Loading branch information
alopezz committed Apr 18, 2023
commit 05b195404266810bf4e476eb03789f031ea5f2b7
14 changes: 13 additions & 1 deletion kafka_consumer/tests/test_integration.py
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,18 @@ def test_config(
'Using both monitor_unlisted_consumer_groups and consumer_groups or consumer_groups_regex',
id="No specified consumer groups, but monitor_unlisted_consumer_groups true",
),
pytest.param(
{
'consumer_groups': {'my_consumer': {'dc': []}},
'consumer_groups_regex': {},
'monitor_unlisted_consumer_groups': True,
},
4,
4,
4,
'Using both monitor_unlisted_consumer_groups and consumer_groups or consumer_groups_regex',
id="Specified topics on consumer_groups, but monitor_unlisted_consumer_groups true",
),
pytest.param(
{
'consumer_groups': {},
Expand All @@ -289,7 +301,7 @@ def test_config(
4,
4,
'Using both monitor_unlisted_consumer_groups and consumer_groups or consumer_groups_regex',
id="Specified topics, but monitor_unlisted_consumer_groups true",
id="Specified topics on consumer_groups_regex, but monitor_unlisted_consumer_groups true",
),
pytest.param(
{
Expand Down