Separate config logic #13975
Closed
Separate config logic #13975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove deprecated implementation of kafka_consumer * Apply suggestions
* remove dsm * remove dsm from metadata.csv
* remove more unused code * revert changes in check
* Add more tests to increase code coverage * change to configerror * unsplit test files * update comments * apply review suggestions
This reverts commit 1492138.
* Map out structure * Combine classes * Remove deprecated call * Remove clazz * Create structure for kafka client classes * Undo * Fix style * Add consumer offset and log collection (#13944) * Refactor broker offset metric collection (#13934) * Add broker offset metric collection * Change import * Clean up broker offset functions and change names * Fix style * Use updated values for check * Clean up functions * Refactor client creation (#13946) * Refactor client creation * Add back e2e test * Remove commented out line * Remove KafkaClient and refactor tests (#13954) * Revert "Remove KafkaClient and refactor tests (#13954)" This reverts commit e327d71. --------- Co-authored-by: Fanny Jiang <fanny.jiang@datadoghq.com>
4f4cae8 to
30143f5
Compare
yzhan289
commented
Feb 15, 2023
| self.check = check | ||
| self.config = config |
There was a problem hiding this comment.
I ended up using self.kafka_config instead of self.config here since self.config is used by the ConfigMixin, but this is only initialized right before the first check run. I wanted to make sure that I avoid any collisions in self.config.
97c64f7 to
423bb34
Compare
|
CI is currently failing since there are still some references to |
b6a8572 to
1efecf5
Compare
|
Closing in favor of #13989 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Additional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attachedqa/skip-qalabel.