Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[datadog_check_base] renamed base check package for consistency #1384

Merged
merged 2 commits into from
Apr 13, 2018
Merged

[datadog_check_base] renamed base check package for consistency #1384

merged 2 commits into from
Apr 13, 2018

Conversation

masci
Copy link
Contributor

@masci masci commented Apr 12, 2018

What does this PR do?

Rename datadog-check-base into datadog_check_base since any other check uses underscores.

Motivation

Consistency

Versioning

Not sure we need to bump any version, the dependency doesn't actually change

@masci masci mentioned this pull request Apr 12, 2018
Closed
ofek
ofek previously approved these changes Apr 12, 2018
View reviewed changes
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@masci masci mentioned this pull request Apr 13, 2018
Merged
truthbk
truthbk approved these changes Apr 13, 2018
View reviewed changes
Copy link
Member

@truthbk truthbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👌

@masci masci merged commit 49e2ae8 into master Apr 13, 2018
@masci masci deleted the massi/baserename branch April 13, 2018 09:26
@ofek ofek mentioned this pull request May 1, 2018
Merged
@olivielpeau olivielpeau mentioned this pull request May 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@truthbk truthbk truthbk approved these changes

@ofek ofek ofek left review comments

Assignees
No one assigned
Labels
changelog/no-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@masci @truthbk @ofek