Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deadlocks monotonic count metric #13374

Merged
merged 20 commits into from
Dec 1, 2022

Conversation

nenadnoveljic
Copy link
Contributor

What does this PR do?

new deadlock metric based on monotonic count

Motivation

see DBM-790
the existing deadlock metric based on rate is confusing

Additional Notes

QueryExecutor API was used

Review checklist (to be `filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

nenadnoveljic and others added 4 commits November 29, 2022 10:53
To avoid repetitive calculations - the tag is used on multiple spots.

Co-authored-by: Alex Barksdale <alex.barksdale@datadoghq.com>
…ataDog/integrations-core into DBM-790-postgres-deadlock-count-metric
@alexandre-normand
Copy link
Contributor

@nenadnoveljic : Process comment: the PR title should be formatted to be friendly to the generated changelog. You can see examples of PR titles here (but note that the [Added] or [Fixed] actually comes from the changelog label and isn't coming from the PR title).

@alexandre-normand
Copy link
Contributor

Oh and it looks like CI is complaining about some formatting issues here. Otherwise, this looks good to me.

@nenadnoveljic nenadnoveljic changed the title DBM-790-postgres-deadlock-count-metric Add deadlocks monotonic count metric Nov 30, 2022
@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Merging #13374 (bde62fa) into master (37ac25f) will increase coverage by 0.00%.
The diff coverage is 86.31%.

Flag Coverage Δ
postgres 91.39% <86.31%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@nenadnoveljic nenadnoveljic merged commit f8c920e into master Dec 1, 2022
@nenadnoveljic nenadnoveljic deleted the DBM-790-postgres-deadlock-count-metric branch December 1, 2022 08:11
@alexbarksdale alexbarksdale restored the DBM-790-postgres-deadlock-count-metric branch December 16, 2022 20:44
@alexbarksdale alexbarksdale deleted the DBM-790-postgres-deadlock-count-metric branch December 16, 2022 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants